Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search API Documentation #333

Merged
merged 5 commits into from
Feb 21, 2022
Merged

Search API Documentation #333

merged 5 commits into from
Feb 21, 2022

Conversation

MRichards99
Copy link
Collaborator

This PR will close #320, #328

Description

This PR updates the documentation to give details of the search API. Along the way, I've cleaned up a few existing things and removed aspects that are difficult to regularly update/get outdated rather quickly (e.g. contents, directory tree).

I've tried to include important bits of how the search API works, including details of how the mapping file works and the simple client handling (compared to DataGateway API anyway).

I've also moved the Postman collection to util/ because the documentation implies that's where it lives, and it seems like a sensible place for it.

No version bump on this PR as there are no code changes.

Testing Instructions

I mean, can you even test a markdown file 🤔

  • Review code
  • Check GitHub Actions build
  • If icatdb Generator Script Consistency Test CI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?
  • Review changes to test coverage
  • Does this change mean a new patch, minor or major version should be made? If so, does one of the commit messages feature fix:, feat: or BREAKING CHANGE: so a release is automatically made via GitHub Actions upon merge?

Agile Board Tracking

Connect to #328

@MRichards99 MRichards99 requested a review from VKTB February 16, 2022 09:55
@MRichards99 MRichards99 linked an issue Feb 16, 2022 that may be closed by this pull request
1 task
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #333 (0a9c05a) into master (11d59e8) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
+ Coverage   92.62%   92.69%   +0.06%     
==========================================
  Files          43       43              
  Lines        3215     3216       +1     
  Branches      321      321              
==========================================
+ Hits         2978     2981       +3     
  Misses        198      198              
+ Partials       39       37       -2     
Impacted Files Coverage Δ
datagateway_api/src/search_api/helpers.py 97.46% <0.00%> (-2.54%) ⬇️
...gateway_api/src/search_api/query_filter_factory.py 95.23% <0.00%> (-0.32%) ⬇️
datagateway_api/src/common/config.py 100.00% <0.00%> (ø)
...agateway_api/src/resources/search_api_endpoints.py 100.00% <0.00%> (ø)
datagateway_api/src/api_start_utils.py 86.29% <0.00%> (+0.45%) ⬆️
datagateway_api/src/search_api/models.py 98.50% <0.00%> (+1.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11d59e8...0a9c05a. Read the comment docs.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
MRichards99 and others added 2 commits February 17, 2022 18:18
Co-authored-by: Viktor Bozhinov <45173816+VKTB@users.noreply.github.com>
@MRichards99 MRichards99 requested a review from VKTB February 17, 2022 18:24
README.md Outdated Show resolved Hide resolved
Co-authored-by: Viktor Bozhinov <45173816+VKTB@users.noreply.github.com>
@MRichards99 MRichards99 requested a review from VKTB February 18, 2022 17:31
@MRichards99 MRichards99 merged commit 60a599e into master Feb 21, 2022
@MRichards99 MRichards99 deleted the search-api-docs-#320 branch February 21, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add details of the search API implementation in the README Update Documentation with Search API Details
2 participants