ICAT to PaNOSC Data Model Conversion

[VKTB]

This PR will close #265

Description

This PR implements the conversion from ICAT to PaNOSC data models. It uses the PaNOSC - ICAT mappings define in the filter-input-conversion branch which is why that is the base branch. All the commits before b0983bb, with exception of 85c4bfc, are as a result of me merging the changes from the base as well as the feature/icat-to-panosc-data-model-conversion-#265 branch.

The PaNOSC fields that map to id fields in ICAT were set to be of type StrictStr but because they are integers in ICAT, the creation of the PaNOSC models was failing because they were only accepting strings. To deal with this issue, the type of such PaNOSC fields were changed to str instead as this casts integers to strings but still throws a ValidationError if None is passed to it. To keep things consistent and less confusing, the types of all the other fields were made non-strict.

A version bump will be made once this is merged.

Testing Instructions

• Review code
• Check GitHub Actions build
• If icatdb Generator Script Consistency Test CI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?
• Review changes to test coverage
• Does this change mean a new patch, minor or major version should be made? If so, does one of the commit messages feature fix:, feat: or BREAKING CHANGE: so a release is automatically made via GitHub Actions upon merge?

Agile Board Tracking

Connect to #265

[MRichards99]

The overall implementation of this looks to work, although the test failures I came across on my machine suggest there's an issue with the parameter mapping. I've left some comments/suggestions as I've been looking through the code

[MRichards99]

Little bit unsure why the CI hasn't run on this PR 🤔 it's not a problem until we get a new release of Python ICAT because it'll just fail right now, but note to future us to maybe run it manually.

[VKTB]

Little bit unsure why the CI hasn't run on this PR 🤔 it's not a problem until we get a new release of Python ICAT because it'll just fail right now, but note to future us to maybe run it manually.

I am not sure what happened there, but it is running now 😄

[codecov]

Codecov Report

Merging #300 (358ac22) into master (63f4f17) will increase coverage by 0.58%.
The diff coverage is 93.02%.

❗ Current head 358ac22 differs from pull request most recent head f17038d. Consider uploading reports for the commit f17038d to get more accurate results

@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
+ Coverage   90.64%   91.22%   +0.58%     
==========================================
  Files          43       43              
  Lines        2982     3066      +84     
  Branches      273      290      +17     
==========================================
+ Hits         2703     2797      +94     
+ Misses        244      230      -14     
- Partials       35       39       +4     

Impacted Files	Coverage Δ
datagateway_api/src/search_api/filters.py	89.61% <80.00%> (+4.61%)	⬆️
datagateway_api/src/search_api/panosc_mappings.py	84.61% <81.25%> (-2.89%)	⬇️
datagateway_api/src/search_api/models.py	96.51% <95.73%> (+9.63%)	⬆️
...gateway_api/src/search_api/query_filter_factory.py	94.95% <100.00%> (+0.17%)	⬆️
...atagateway_api/src/datagateway_api/icat/filters.py	99.37% <0.00%> (-0.04%)	⬇️
datagateway_api/src/common/filters.py	100.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63f4f17...f17038d. Read the comment docs.