Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade werkzeug for security reasons #278

Merged
merged 2 commits into from
Nov 1, 2021

Conversation

MRichards99
Copy link
Collaborator

@MRichards99 MRichards99 commented Nov 1, 2021

Description

This morning I noticed that the safety job on this repo's CI is failing due to an old version of werkzeug (see https://github.com/ral-facilities/datagateway-api/runs/4066918019?check_suite_focus=true). I have upgraded the version of this to satisfy that job.

Testing Instructions

  • Review code
  • Check GitHub Actions build
  • If icatdb Generator Script Consistency Test CI job fails, is this because of a
    deliberate change made to the script to change generated data (which isn't
    actually a problem) or is there an underlying issue with the changes made?
  • Review changes to test coverage

Agile Board Tracking

Connect to #{issue number}

@MRichards99 MRichards99 requested a review from VKTB November 1, 2021 12:05
@MRichards99 MRichards99 changed the base branch from master to bugfix/default-python-version November 1, 2021 12:05
@MRichards99
Copy link
Collaborator Author

Ignore the failing check from 'Semantic Pull Request'. This tool will be used for the versioning i.e. once #242 is closed.

- To fix issue described in a Flask RESTful PR: flask-restful/flask-restful#913
@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #278 (ca14c35) into bugfix/default-python-version (42c29be) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                      Coverage Diff                       @@
##           bugfix/default-python-version     #278   +/-   ##
==============================================================
  Coverage                          91.23%   91.23%           
==============================================================
  Files                                 32       32           
  Lines                               2395     2395           
  Branches                             205      205           
==============================================================
  Hits                                2185     2185           
  Misses                               186      186           
  Partials                              24       24           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42c29be...ca14c35. Read the comment docs.

@MRichards99 MRichards99 merged commit 9ef4f8e into bugfix/default-python-version Nov 1, 2021
@MRichards99 MRichards99 deleted the upgrade-werkzeug branch November 1, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants