Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Test Coverage #218

Merged
merged 11 commits into from
Apr 12, 2021
Merged

Increase Test Coverage #218

merged 11 commits into from
Apr 12, 2021

Conversation

MRichards99
Copy link
Collaborator

@MRichards99 MRichards99 commented Apr 8, 2021

This PR will close #217

Description

This branch has some changes I've been working on throughout the week regarding test coverage. Each commit has a distinct test case covered, so referring to the commit messages probably gives the most detail about the changes (without me repeating it here).

One thing worthy of note is that there's not much test coverage increase on query.py. I'm leaving this until I fix the distinct filter stuff on another branch, at which point I'll test query.py more thoroughly on that branch.

Testing Instructions

  • Review code
  • Check GitHub Actions build
  • Review changes to test coverage

Agile Board Tracking

Connect to #217

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #218 (e6aee90) into master (0601fb2) will increase coverage by 1.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
+ Coverage   87.95%   89.16%   +1.20%     
==========================================
  Files          29       29              
  Lines        2317     2317              
  Branches      193      193              
==========================================
+ Hits         2038     2066      +28     
+ Misses        242      220      -22     
+ Partials       37       31       -6     
Impacted Files Coverage Δ
datagateway_api/common/backends.py 100.00% <ø> (+20.00%) ⬆️
datagateway_api/common/icat/filters.py 97.61% <0.00%> (+1.58%) ⬆️
datagateway_api/common/config.py 100.00% <0.00%> (+2.53%) ⬆️
datagateway_api/common/filters.py 100.00% <0.00%> (+4.54%) ⬆️
datagateway_api/common/icat/helpers.py 92.52% <0.00%> (+5.14%) ⬆️
datagateway_api/common/helpers.py 93.84% <0.00%> (+7.69%) ⬆️
datagateway_api/common/exceptions.py 100.00% <0.00%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0601fb2...e6aee90. Read the comment docs.

@MRichards99 MRichards99 merged commit 1b7944c into master Apr 12, 2021
@MRichards99 MRichards99 deleted the refactor/increase-test-coverage branch April 12, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase Test Coverage for ICAT Backend
2 participants