Bugfix/include distinct requests #211 #212
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will close #211
Description
This fixes a bug found when making an e2e test pass on DataGateway regarding included attributes on a distinct filter (linked issue has more details about this). I added some unit tests for this work, to test that this functionality works as intended (
test_prepare_distinct_fields()
). I increased test coverage a bit too -test_valid_distinct_attribute_mapping()
,test_invalid_distinct_attribute_mapping()
and changes intest_session_handling.py
.There's some dependency updates, as
safety
is requesting they be updated for the CI to pass.Testing Instructions
For the request shown in the issue, this is the correct response (assuming the API is pointing at preprod's ICAT):
Agile Board Tracking
Connect to #211