Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WSGI script and fix errors with pip install #207

Merged
merged 7 commits into from
Feb 26, 2021
Merged

Conversation

ajkyffin
Copy link
Member

Description

  • Adds wsgi.py for running with Apache mod_wsgi
  • Adds requests as a run-time dependency
  • Moves config.json(.example) into the datagateway_api package (previously hard-coded as being in the directory underneath the package directory which is the python site-packages directory when installed)

Testing Instructions

Mostly just need to check that I haven't broken anything.

  • Review code
  • Check GitHub Actions build
  • Check that moving config.json hasn't broken anything
  • Test installation into a virtualenv using pip
  • (optional) Test running with mod_wsgi

@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #207 (1572c0c) into master (856c31e) will decrease coverage by 0.15%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   87.10%   86.94%   -0.16%     
==========================================
  Files          27       28       +1     
  Lines        2225     2229       +4     
  Branches      193      193              
==========================================
  Hits         1938     1938              
- Misses        246      250       +4     
  Partials       41       41              
Impacted Files Coverage Δ
datagateway_api/wsgi.py 0.00% <0.00%> (ø)
datagateway_api/common/config.py 97.46% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 856c31e...1572c0c. Read the comment docs.

@MRichards99 MRichards99 self-assigned this Feb 18, 2021
Conflicts:
	poetry.lock
	pyproject.toml
MRichards99
MRichards99 previously approved these changes Feb 18, 2021
@ajkyffin ajkyffin merged commit 04eafd5 into master Feb 26, 2021
@MRichards99 MRichards99 deleted the feature/wsgi branch April 26, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants