Recreate SQL Dependency PR #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dencies - This will help keep consistent versions of flake8 etc being installed between developers, to prevent incosistent linting/safety outputs
- Done by `pre-commit run --all-files`
- These files have been replaced by the use of Poetry to store the API's dependencies
…anges on this branch
- This is so flake8 can correctly detect which import statements are bringing in local code, so said statements can be ordered in a consistent style
- This is the suggested line length defined by Black, which flake8 is configured to also follow
- S311 (from Bandit) states "Standard pseudo-random generators are not suitable for security/cryptographic purposes.". The generator script doesn't generate data that would be vulnerable to security (no keys or anything of that nature is created using the random library) hence this status code is ignored
- This linting status code is regarding passing an exception object directly into log.exception()
- I've had to increase the max complexity in .flake8 because there's not much you can do with a couple of the functions. Still made some improvements though!
- This will mean this configurable parameter can be disabled when running the API in production, thereby avoiding any issues with read-only directories
- Some dependencies require Python >=3.6
- It can be useful to let all versions complete to give a better picture of the issues
- This was not used, with the codecov GitHub Actions plugin used instead
- This is no longer needed, I've opted to use the GitHub Actions codecov plugin
Add Code Coverage Reports
Implement GitHub Actions Workflow
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
=========================================
Coverage ? 87.25%
=========================================
Files ? 28
Lines ? 2221
Branches ? 192
=========================================
Hits ? 1938
Misses ? 242
Partials ? 41 Continue to review full report at Codecov.
|
stuartpullinger
approved these changes
Jan 21, 2021
|
Yeah I'm not sure why they didn't fail before, but it's all good now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take 2, other PR is failing on CI, not sure if it's because of the logging branch or not.