Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only one include filter can be applied at a time #39

Closed
keiranjprice101 opened this issue Aug 15, 2019 · 2 comments · Fixed by #66
Closed

Only one include filter can be applied at a time #39

keiranjprice101 opened this issue Aug 15, 2019 · 2 comments · Fixed by #66
Labels
enhancement New feature or request

Comments

@keiranjprice101
Copy link
Collaborator

Include filtering allows only one filter a time. It can be many included relations in the include, but not multiple given as separate query string parameters

@keiranjprice101 keiranjprice101 added the enhancement New feature or request label Aug 15, 2019
@keiranjprice101
Copy link
Collaborator Author

@louise-davies Is this really an issue, would there be a time where it should be allowed to give a query such as /datafiles?include=["DATASET"]&include=["DATAFILEFORMAT"] when it can just work as
/datafiles?include=["DATASET","DATAFILEFORMAT"]

@louise-davies
Copy link
Member

@keiranjprice101 If it is difficult then feel free to enforce that there can only be one include filter - just make sure to document it and perhaps have a specific error message sent back to the client if they do have more than one? It doesn't impact how the frontend uses it - it either only uses one include and if there was a future where there are two separate includes I can just parse them and merge them together and send them in the same query param

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants