Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Count Endpoints #267

Closed
2 tasks
MRichards99 opened this issue Sep 23, 2021 · 0 comments · Fixed by #302
Closed
2 tasks

Implement Count Endpoints #267

MRichards99 opened this issue Sep 23, 2021 · 0 comments · Fixed by #302
Labels
enhancement New feature or request expands-search-api Issues relating to the ExPaNDS Search API section of this repo

Comments

@MRichards99
Copy link
Collaborator

Description:
This covers the following endpoints:

  • GET /datasets/{pid}/files/count
  • GET /datasets/count
  • GET /documents/count
  • GET /instruments/count

Each of these endpoints only accepts the where as a query parameter (rather than filter) so only the WHERE filter is supported here. This should be implemented elsewhere but should be noted as a reminder. The following format should be used as a response which is slightly different to DataGateway API:

{
    "count": 15
}

Acceptance criteria:

  • Implement each endpoint
  • Write test cases to cover each endpoint
@MRichards99 MRichards99 added enhancement New feature or request expands-search-api Issues relating to the ExPaNDS Search API section of this repo labels Sep 23, 2021
@MRichards99 MRichards99 linked a pull request Jan 31, 2022 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request expands-search-api Issues relating to the ExPaNDS Search API section of this repo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant