Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Search API Limit Filter #262

Closed
1 task
MRichards99 opened this issue Sep 23, 2021 · 0 comments · Fixed by #295
Closed
1 task

Implement Search API Limit Filter #262

MRichards99 opened this issue Sep 23, 2021 · 0 comments · Fixed by #295
Assignees
@VKTB
Labels
enhancement New feature or request expands-search-api Issues relating to the ExPaNDS Search API section of this repo

Comments

@MRichards99
Copy link
Collaborator

Description:
The limit filter follows the same syntax as DataGateway API, though is part of the all-in-one query parameter. This shouldn't require too much work, just integrating it with the Search API.

Acceptance criteria:

  • Get limit filter working with Search API
@MRichards99 MRichards99 added enhancement New feature or request expands-search-api Issues relating to the ExPaNDS Search API section of this repo labels Sep 23, 2021
VKTB pushed a commit that referenced this issue Dec 2, 2021
test: create ICAT related test fixtures #262 #263
2eb14cf
VKTB pushed a commit that referenced this issue Dec 2, 2021
test: add tests for TestSearchAPILimitFilter #262
7257672
@VKTB VKTB mentioned this issue Dec 2, 2021
Merged
5 tasks
@VKTB VKTB self-assigned this Dec 2, 2021
VKTB pushed a commit that referenced this issue Dec 6, 2021
test: fix imports #262 #263
7310707
@VKTB VKTB closed this as completed in #295 Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VKTB VKTB

Labels
enhancement New feature or request expands-search-api Issues relating to the ExPaNDS Search API section of this repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Limit and Skip filters ral-facilities/datagateway-api
2 participants
@MRichards99 @VKTB