Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insensitive Like Operator #243

Closed
2 tasks
MRichards99 opened this issue Aug 9, 2021 · 1 comment · Fixed by #273
Closed
2 tasks

Insensitive Like Operator #243

MRichards99 opened this issue Aug 9, 2021 · 1 comment · Fixed by #273
Assignees
Labels
icat backend Issues relating to the Python ICAT backend

Comments

@MRichards99
Copy link
Collaborator

Description:
Just an issue for the action in ral-facilities/datagateway#731.

Once icatproject/python-icat#86 has been solved, closed and merged, I need to update the like operator on DataGateway API to pass UPPER() into query. This will make our like operator case insensitive on production ICATs which use Oracle databases.

I already have these changes in a stash so I just need to write some tests to prove the where filter stores the upper function.

Acceptance criteria:

  • Update like operator to use SQL upper function
  • Add some tests to explicitly test this within the where filter
@MRichards99 MRichards99 added the icat backend Issues relating to the Python ICAT backend label Aug 9, 2021
@MRichards99 MRichards99 self-assigned this Aug 9, 2021
@MRichards99
Copy link
Collaborator Author

Blocked until icatproject/python-icat#86 is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icat backend Issues relating to the Python ICAT backend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant