You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description:
On the ICAT backend, if any of the tests prefixed with test_valid in test_create_icat.py fail, the data that gets created from those tests won't get removed, thereby not leaving icatdb into a clean state once the tests have finished running. This happens because the data is removed at the end of the test function (after the assert statement) so any code after that won't run if it throws an AssertionError.
Acceptance criteria:
All tests should still pass
If any tests in test_create_icat.py with the test_valid prefix are provoked to fail, the investigations table on icatdb should still be in the same state that it started. This can be indirectly checked through the other tests - if it hasn't been fixed, there'll be lots of other test failures where investigation data is involved
The text was updated successfully, but these errors were encountered:
- This replaces the data deletion loop that was after the assert statement, which wouldn't run if the an AssertionError was raised, resulting in undeleted test data
Description:
On the ICAT backend, if any of the tests prefixed with
test_valid
intest_create_icat.py
fail, the data that gets created from those tests won't get removed, thereby not leaving icatdb into a clean state once the tests have finished running. This happens because the data is removed at the end of the test function (after theassert
statement) so any code after that won't run if it throws anAssertionError
.Acceptance criteria:
test_create_icat.py
with thetest_valid
prefix are provoked to fail, the investigations table onicatdb
should still be in the same state that it started. This can be indirectly checked through the other tests - if it hasn't been fixed, there'll be lots of other test failures where investigation data is involvedThe text was updated successfully, but these errors were encountered: