Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log file location should be configurable #182

Closed
ajkyffin opened this issue Oct 28, 2020 · 1 comment · Fixed by #188
Closed

Log file location should be configurable #182

ajkyffin opened this issue Oct 28, 2020 · 1 comment · Fixed by #188
Milestone
Software Engineer...

Comments

@ajkyffin
Copy link
Member

On a production system the log files should be in /var/log, so the log file location needs to be configurable.
MRichards99 added a commit that referenced this issue Nov 6, 2020
@MRichards99
#182: Add log location configuration option
b56c4e7
MRichards99 added a commit that referenced this issue Nov 6, 2020
@MRichards99
#182: Allow log file to be configured
b6c786b 
- In production, this will be used to store the API's logs in /var/log/
- Also remove an unused variable that I noticed
MRichards99 added a commit that referenced this issue Nov 6, 2020
@MRichards99
#182: Add log location configuration option
7723d69
MRichards99 added a commit that referenced this issue Nov 6, 2020
@MRichards99
#182: Allow log file to be configured
45b5896 
- In production, this will be used to store the API's logs in /var/log/
- Also remove an unused variable that I noticed
@MRichards99 MRichards99 mentioned this issue Nov 6, 2020
Merged
@MRichards99 MRichards99 linked a pull request Nov 6, 2020 that will close this issue
Allow Log File Location to be Configurable #188
Merged
@MRichards99
Copy link
Collaborator

The PR associated with this issue has been reviewed and merged, but because it hasn't been merged into master, it hasn't been closed automatically, but the work for this issue has been completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Software Engineering improvements
Development

Successfully merging a pull request may close this issue.

Allow Log File Location to be Configurable ral-facilities/datagateway-api
2 participants
@ajkyffin @MRichards99