Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement the order/sort filter for python-icat #140

Closed
stuartpullinger opened this issue Jun 17, 2020 · 1 comment · Fixed by #158
Closed

implement the order/sort filter for python-icat #140

stuartpullinger opened this issue Jun 17, 2020 · 1 comment · Fixed by #158
Assignees
@MRichards99
Milestone
Implement basic f...

Comments

@stuartpullinger
Copy link
Contributor

ie. ascending or descending
MRichards99 added a commit that referenced this issue Aug 18, 2020
@MRichards99
#140: Fix DB order filter from an import error
4bee04b
MRichards99 added a commit that referenced this issue Aug 18, 2020
@MRichards99
#140: Move FilterOrderHandler into its own file
78ef98e 
- This will remove circular imports in a later change
- Also helps to tidy up the code base by separating the filter handler from the abstract classes of the filters
MRichards99 added a commit that referenced this issue Aug 18, 2020
@MRichards99
#140: Basic implementation of ICAT order filter
578ac21 
- If there's more than one order filter in a request, the others get overwritten due to the way setOrder() works in Python ICAT
MRichards99 added a commit that referenced this issue Aug 18, 2020
@MRichards99
#140: Remove unused imports
19a286b
MRichards99 added a commit that referenced this issue Aug 18, 2020
@MRichards99
#140: Move create_condition() to PythonICATWhereFilter
51924f8 
- This is to remove a circular dependency that I found while implementing an order filter
- Also added a couple of __init__.py files which didn't previously exist
MRichards99 added a commit that referenced this issue Aug 19, 2020
@MRichards99
#140: Allow multiple order filters to be used in conjunction
aec81f1
MRichards99 added a commit that referenced this issue Aug 19, 2020
@MRichards99
#140: Add docstrings
182d054
@MRichards99 MRichards99 mentioned this issue Aug 19, 2020
Merged
@MRichards99 MRichards99 self-assigned this Aug 20, 2020
@MRichards99 MRichards99 linked a pull request Aug 20, 2020 that will close this issue
Implement Order Filter for Python ICAT Backend #158
Merged
MRichards99 added a commit that referenced this issue Aug 26, 2020
@MRichards99
#140: Make suggested changes as per PR comments
8c1dcd7
@MRichards99
Copy link
Collaborator

Code merged into master, hence issue being closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MRichards99 MRichards99

Labels
None yet
Projects
None yet
Milestone
Implement basic filters
Development

Successfully merging a pull request may close this issue.

Implement Order Filter for Python ICAT Backend ral-facilities/datagateway-api
2 participants
@stuartpullinger @MRichards99