Skip to content

Commit

Permalink
Fix imports for new directory structure
Browse files Browse the repository at this point in the history
- Directory structure due to implementation of search API
  • Loading branch information
MRichards99 committed Oct 26, 2021
1 parent ef5973e commit ea68ce3
Show file tree
Hide file tree
Showing 41 changed files with 137 additions and 87 deletions.
4 changes: 2 additions & 2 deletions datagateway_api/common/datagateway_api/backends.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import sys

from datagateway_api.common.database.backend import DatabaseBackend
from datagateway_api.common.icat.backend import PythonICATBackend
from datagateway_api.common.datagateway_api.database.backend import DatabaseBackend
from datagateway_api.common.datagateway_api.icat.backend import PythonICATBackend


def create_backend(backend_type):
Expand Down
6 changes: 3 additions & 3 deletions datagateway_api/common/datagateway_api/database/backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
from sqlalchemy import inspect
from sqlalchemy.exc import SQLAlchemyError

from datagateway_api.common.backend import Backend
from datagateway_api.common.constants import Constants
from datagateway_api.common.database.helpers import (
from datagateway_api.common.datagateway_api.backend import Backend
from datagateway_api.common.datagateway_api.database.helpers import (
create_rows_from_json,
db,
delete_row_by_id,
Expand All @@ -24,7 +24,7 @@
requires_session_id,
update_row_from_id,
)
from datagateway_api.common.database.models import SESSION
from datagateway_api.common.datagateway_api.database.models import SESSION
from datagateway_api.common.exceptions import AuthenticationError, DatabaseError
from datagateway_api.common.helpers import get_entity_object_from_name, queries_records

Expand Down
4 changes: 2 additions & 2 deletions datagateway_api/common/datagateway_api/database/filters.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def add_query_join(self, query):
filter
:param query: The query to have filters applied to
:type query: :class:`datagateway_api.common.database.helpers.[QUERY]`
:type query: :class:`.common.datagateway_api.database.helpers.[QUERY]`
"""

if self.related_related_field:
Expand All @@ -92,7 +92,7 @@ def get_entity_model_for_filter(self, query):
variables of this class
:param query: The query to have filters applied to
:type query: :class:`datagateway_api.common.database.helpers.[QUERY]`
:type query: :class:`.common.datagateway_api.database.helpers.[QUERY]`
:return: Entity model of the field (usually the field relating to the endpoint
the request is coming from)
"""
Expand Down
8 changes: 5 additions & 3 deletions datagateway_api/common/datagateway_api/database/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,25 +6,27 @@
from flask_sqlalchemy import SQLAlchemy
from sqlalchemy.orm import aliased

from datagateway_api.common.database.filters import (
from datagateway_api.common.datagateway_api.database.filters import (
DatabaseDistinctFieldFilter,
DatabaseIncludeFilter as IncludeFilter,
DatabaseWhereFilter as WhereFilter,
)
from datagateway_api.common.database.models import (
from datagateway_api.common.datagateway_api.database.models import (
FACILITY,
FACILITYCYCLE,
INSTRUMENT,
INVESTIGATION,
INVESTIGATIONINSTRUMENT,
SESSION,
)
from datagateway_api.common.datagateway_api.filter_order_handler import (
FilterOrderHandler,
)
from datagateway_api.common.exceptions import (
AuthenticationError,
BadRequestError,
MissingRecordError,
)
from datagateway_api.common.filter_order_handler import FilterOrderHandler
from datagateway_api.common.helpers import map_distinct_attributes_to_results


Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import logging

from datagateway_api.common.icat.filters import (
from datagateway_api.common.datagateway_api.icat.filters import (
PythonICATLimitFilter,
PythonICATOrderFilter,
PythonICATSkipFilter,
Expand Down
8 changes: 4 additions & 4 deletions datagateway_api/common/datagateway_api/icat/backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,9 @@

from icat.exception import ICATError, ICATSessionError

from datagateway_api.common.backend import Backend
from datagateway_api.common.constants import Constants
from datagateway_api.common.exceptions import AuthenticationError, PythonICATError
from datagateway_api.common.helpers import queries_records
from datagateway_api.common.icat.helpers import (
from datagateway_api.common.datagateway_api.backend import Backend
from datagateway_api.common.datagateway_api.icat.helpers import (
create_entities,
delete_entity_by_id,
get_cached_client,
Expand All @@ -25,6 +23,8 @@
update_entities,
update_entity_by_id,
)
from datagateway_api.common.exceptions import AuthenticationError, PythonICATError
from datagateway_api.common.helpers import queries_records


log = logging.getLogger()
Expand Down
17 changes: 9 additions & 8 deletions datagateway_api/common/datagateway_api/icat/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,22 @@
ICATValidationError,
)

from datagateway_api.common.datagateway_api.filter_order_handler import (
FilterOrderHandler,
)
from datagateway_api.common.datagateway_api.icat.filters import (
PythonICATLimitFilter,
PythonICATWhereFilter,
)
from datagateway_api.common.datagateway_api.icat.lru_cache import ExtendedLRUCache
from datagateway_api.common.datagateway_api.icat.query import ICATQuery
from datagateway_api.common.date_handler import DateHandler
from datagateway_api.common.exceptions import (
AuthenticationError,
BadRequestError,
MissingRecordError,
PythonICATError,
)
from datagateway_api.common.filter_order_handler import FilterOrderHandler
from datagateway_api.common.icat.filters import (
PythonICATLimitFilter,
PythonICATWhereFilter,
)
from datagateway_api.common.icat.lru_cache import ExtendedLRUCache
from datagateway_api.common.icat.query import ICATQuery


log = logging.getLogger()

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def get_query_filter(request_filter):

backend_type = config.get_config_value(APIConfigOptions.BACKEND)
if backend_type == "db":
from datagateway_api.common.database.filters import (
from datagateway_api.common.datagateway_api.database.filters import (
DatabaseDistinctFieldFilter as DistinctFieldFilter,
DatabaseIncludeFilter as IncludeFilter,
DatabaseLimitFilter as LimitFilter,
Expand All @@ -38,7 +38,7 @@ def get_query_filter(request_filter):
DatabaseWhereFilter as WhereFilter,
)
elif backend_type == "python_icat":
from datagateway_api.common.icat.filters import (
from datagateway_api.common.datagateway_api.icat.filters import (
PythonICATDistinctFieldFilter as DistinctFieldFilter,
PythonICATIncludeFilter as IncludeFilter,
PythonICATLimitFilter as LimitFilter,
Expand Down
12 changes: 8 additions & 4 deletions datagateway_api/common/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@
from flask_restful import reqparse
from sqlalchemy.exc import IntegrityError

from datagateway_api.common.database import models
from datagateway_api.common.datagateway_api.database import models
from datagateway_api.common.datagateway_api.query_filter_factory import (
QueryFilterFactory,
)
from datagateway_api.common.date_handler import DateHandler
from datagateway_api.common.exceptions import (
ApiError,
Expand All @@ -17,8 +20,9 @@
FilterError,
MissingCredentialsError,
)
from datagateway_api.common.query_filter_factory import QueryFilterFactory
from datagateway_api.src.resources.entities.entity_endpoint_dict import endpoints
from datagateway_api.src.resources.datagateway_api.entities.entity_endpoint_dict import (
endpoints,
)

log = logging.getLogger()

Expand Down Expand Up @@ -115,7 +119,7 @@ def get_entity_object_from_name(entity_name):
:param entity_name: Name of the entity to fetch a version from this model
:type entity_name: :class:`str`
:return: Object of the entity requested (e.g.
:class:`datagateway_api.common.database.models.INVESTIGATIONINSTRUMENT`)
:class:`.datagateway_api.database.models.INVESTIGATIONINSTRUMENT`)
:raises: KeyError: If an entity model cannot be found as a class in this model
"""
try:
Expand Down
2 changes: 1 addition & 1 deletion datagateway_api/common/search_api/filters.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from datagateway_api.common.icat.filters import (
from datagateway_api.common.datagateway_api.icat.filters import (
PythonICATIncludeFilter,
PythonICATLimitFilter,
PythonICATSkipFilter,
Expand Down
2 changes: 1 addition & 1 deletion datagateway_api/common/search_api/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class PaNOSCAttribute(ABC):
@abstractclassmethod
def from_icat(cls):
def from_icat(self):
pass

@abstractmethod
Expand Down
3 changes: 3 additions & 0 deletions datagateway_api/common/search_api/session_handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,12 @@ def requires_session_id(method):
"""
TODO
"""
pass

"""
@wraps(method)
def wrapper_requires_session(*args, **kwargs):
pass
return wrapper_requires_session
"""
22 changes: 14 additions & 8 deletions datagateway_api/src/api_start_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,22 +7,28 @@
from flask_restful import Api
from flask_swagger_ui import get_swaggerui_blueprint

from datagateway_api.common.backends import create_backend
from datagateway_api.common.config import APIConfigOptions, config
from datagateway_api.common.database.helpers import db
from datagateway_api.common.icat.icat_client_pool import create_client_pool
from datagateway_api.src.resources.entities.entity_endpoint import (
from datagateway_api.common.datagateway_api.backends import create_backend
from datagateway_api.common.datagateway_api.database.helpers import db
from datagateway_api.common.datagateway_api.icat.icat_client_pool import (
create_client_pool,
)
from datagateway_api.src.resources.datagateway_api.entities.entity_endpoint import (
get_count_endpoint,
get_endpoint,
get_find_one_endpoint,
get_id_endpoint,
)
from datagateway_api.src.resources.entities.entity_endpoint_dict import endpoints
from datagateway_api.src.resources.non_entities.ping_endpoint import ping_endpoint
from datagateway_api.src.resources.non_entities.sessions_endpoints import (
from datagateway_api.src.resources.datagateway_api.entities.entity_endpoint_dict import (
endpoints,
)
from datagateway_api.src.resources.datagateway_api.non_entities.ping_endpoint import (
ping_endpoint,
)
from datagateway_api.src.resources.datagateway_api.non_entities.sessions_endpoints import (
session_endpoints,
)
from datagateway_api.src.resources.table_endpoints.table_endpoints import (
from datagateway_api.src.resources.datagateway_api.table_endpoints.table_endpoints import (
count_instrument_facility_cycles_endpoint,
count_instrument_investigation_endpoint,
instrument_facility_cycles_endpoint,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
from sqlalchemy.inspection import inspect

from datagateway_api.common.helpers import get_entity_object_from_name
from datagateway_api.src.resources.entities.entity_endpoint_dict import endpoints
from datagateway_api.src.resources.datagateway_api.entities.entity_endpoint_dict import (
endpoints,
)


def type_conversion(python_type):
Expand Down
4 changes: 3 additions & 1 deletion datagateway_api/src/swagger/initialise_spec.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
from datagateway_api.src.resources.entities.entity_map import create_entity_models
from datagateway_api.src.resources.datagateway_api.entities.entity_map import (
create_entity_models,
)


def initialise_spec(spec):
Expand Down
4 changes: 2 additions & 2 deletions test/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
from flask import Flask
import pytest

from datagateway_api.common.database.helpers import (
from datagateway_api.common.datagateway_api.database.helpers import (
delete_row_by_id,
insert_row_into_table,
)
from datagateway_api.common.database.models import SESSION
from datagateway_api.common.datagateway_api.database.models import SESSION
from datagateway_api.src.api_start_utils import (
create_api_endpoints,
create_app_infrastructure,
Expand Down
4 changes: 2 additions & 2 deletions test/db/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
import pytest

from datagateway_api.common.constants import Constants
from datagateway_api.common.database.helpers import (
from datagateway_api.common.datagateway_api.database.helpers import (
delete_row_by_id,
insert_row_into_table,
)
from datagateway_api.common.database.models import (
from datagateway_api.common.datagateway_api.database.models import (
FACILITYCYCLE,
INSTRUMENT,
INVESTIGATION,
Expand Down
2 changes: 1 addition & 1 deletion test/db/endpoints/test_ping_db.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
import pytest
from sqlalchemy.exc import SQLAlchemyError

from datagateway_api.common.backends import create_backend
from datagateway_api.common.constants import Constants
from datagateway_api.common.datagateway_api.backends import create_backend
from datagateway_api.common.exceptions import DatabaseError


Expand Down
6 changes: 4 additions & 2 deletions test/db/test_database_filter_utilities.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import pytest

from datagateway_api.common.database.filters import DatabaseFilterUtilities
from datagateway_api.common.database.helpers import ReadQuery
from datagateway_api.common.datagateway_api.database.filters import (
DatabaseFilterUtilities,
)
from datagateway_api.common.datagateway_api.database.helpers import ReadQuery
from datagateway_api.common.exceptions import FilterError
from datagateway_api.common.helpers import get_entity_object_from_name

Expand Down
2 changes: 1 addition & 1 deletion test/db/test_entity_helper.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import pytest

from datagateway_api.common.constants import Constants
from datagateway_api.common.database.models import (
from datagateway_api.common.datagateway_api.database.models import (
DATAFILE,
DATAFILEFORMAT,
DATASET,
Expand Down
6 changes: 4 additions & 2 deletions test/db/test_query_filter_factory.py
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
import pytest

from datagateway_api.common.database.filters import (
from datagateway_api.common.datagateway_api.database.filters import (
DatabaseDistinctFieldFilter,
DatabaseIncludeFilter,
DatabaseLimitFilter,
DatabaseOrderFilter,
DatabaseSkipFilter,
DatabaseWhereFilter,
)
from datagateway_api.common.query_filter_factory import QueryFilterFactory
from datagateway_api.common.datagateway_api.query_filter_factory import (
QueryFilterFactory,
)


class TestQueryFilterFactory:
Expand Down
6 changes: 4 additions & 2 deletions test/icat/endpoints/test_ping_icat.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@
from icat.exception import ICATError
import pytest

from datagateway_api.common.backends import create_backend
from datagateway_api.common.constants import Constants
from datagateway_api.common.datagateway_api.backends import create_backend
from datagateway_api.common.datagateway_api.icat.icat_client_pool import (
create_client_pool,
)
from datagateway_api.common.exceptions import PythonICATError
from datagateway_api.common.icat.icat_client_pool import create_client_pool


class TestICATPing:
Expand Down
4 changes: 3 additions & 1 deletion test/icat/filters/test_distinct_filter.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import pytest

from datagateway_api.common.datagateway_api.icat.filters import (
PythonICATDistinctFieldFilter,
)
from datagateway_api.common.exceptions import FilterError
from datagateway_api.common.icat.filters import PythonICATDistinctFieldFilter


class TestICATDistinctFilter:
Expand Down
2 changes: 1 addition & 1 deletion test/icat/filters/test_include_filter.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import pytest

from datagateway_api.common.datagateway_api.icat.filters import PythonICATIncludeFilter
from datagateway_api.common.exceptions import FilterError
from datagateway_api.common.icat.filters import PythonICATIncludeFilter


class TestICATIncludeFilter:
Expand Down
Loading

0 comments on commit ea68ce3

Please sign in to comment.