test: add tests to increase test coverage #259

- `test_get_condition_values()` didn't resolve the partial branch coverage but I thought I'd commit it regardless because it might help us later on

datagateway_api/src/common/base_query_filter_factory.py

@@ -1,7 +1,7 @@
-from abc import abstractstaticmethod
+from abc import ABC, abstractstaticmethod
 
 
-class QueryFilterFactory(object):
+class QueryFilterFactory(ABC):
     @abstractstaticmethod
     def get_query_filter(request_filter, entity_name=None):  # noqa: B902, N805
         """

test/search_api/test_search_api_query_filter_factory.py

@@ -2004,3 +2004,25 @@ def test_valid_filter_input_with_all_filters(
     def test_invalid_filter_input(self, test_request_filter):
         with pytest.raises(FilterError):
             SearchAPIQueryFilterFactory.get_query_filter(test_request_filter)
+
+    @pytest.mark.parametrize(
+        "filter_input, expected_return",
+        [
+            pytest.param(
+                {"property": "value"},
+                ("property", "value", "eq"),
+                id="No operator specified",
+            ),
+            pytest.param(
+                {"property": {"ne": "value"}},
+                ("property", "value", "ne"),
+                id="Specific operator given in input",
+            ),
+        ],
+    )
+    def test_get_condition_values(self, filter_input, expected_return):
+        test_condition_values = SearchAPIQueryFilterFactory.get_condition_values(
+            filter_input,
+        )
+
+        assert test_condition_values == expected_return

test/test_base_query_filter_factory.py

@@ -0,0 +1,15 @@
+from datagateway_api.src.common.base_query_filter_factory import QueryFilterFactory
+
+
+class TestBaseQueryFilterFactory:
+    def test_abstract_class(self):
+        QueryFilterFactory.__abstractmethods__ = set()
+
+        class DummyQueryFilterFactory(QueryFilterFactory):
+            pass
+
+        d = DummyQueryFilterFactory()
+
+        request_filter = "request_filter"
+
+        assert d.get_query_filter(request_filter) is None

test/test_get_filters_from_query.py

@@ -1,6 +1,6 @@
 import pytest
 
-from datagateway_api.src.common.exceptions import FilterError
+from datagateway_api.src.common.exceptions import ApiError, FilterError
 from datagateway_api.src.common.helpers import get_filters_from_query_string
 from datagateway_api.src.datagateway_api.database.filters import (
     DatabaseDistinctFieldFilter,
@@ -52,3 +52,15 @@ def test_valid_multiple_filters(self, flask_test_app_db):
             filters = get_filters_from_query_string("datagateway_api")
 
             assert len(filters) == 2
+
+    def test_valid_search_api_filter(self, flask_test_app_db):
+        with flask_test_app_db:
+            flask_test_app_db.get('/?filter={"skip": 5, "limit": 10}')
+
+            filters = get_filters_from_query_string("search_api", "Dataset")
+
+            assert len(filters) == 2
+
+    def test_invalid_api_type(self):
+        with pytest.raises(ApiError):
+            get_filters_from_query_string("unknown_api")