Skip to content

Commit

Permalink
#246: Add continue-on-error keyword to generator script CI job
Browse files Browse the repository at this point in the history
  • Loading branch information
MRichards99 committed Aug 11, 2021
1 parent 4c41b71 commit d66512a
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/ci-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ jobs:

generator-script-testing:
runs-on: ubuntu-16.04
continue-on-error: true
name: icatdb Generator Script Consistency Test
steps:
- name: Add apt repo
Expand Down Expand Up @@ -262,6 +263,8 @@ jobs:

# NOTE: If a delibrate change is made to the script that will change the data generated,
# the diff (and therefore this job) will fail. If this is the case, don't be alarmed.
# The `continue-on-error` keyword has been added to this job so the workflow should
# pass when the PR is merged in, even if this job fails.
# But, if you didn't mean to change the output of the script, there is likely a
# problem with the changes made that will make the generator script's data
# different to SciGateway preprod
Expand Down

0 comments on commit d66512a

Please sign in to comment.