Skip to content

Commit

Permalink
refactor: make filters mandatory #260
Browse files Browse the repository at this point in the history
- When called from an endpoint, `filters` will always be passed in, even if it is an empty list
  • Loading branch information
MRichards99 committed Dec 20, 2021
1 parent 5f2c2be commit b256eaf
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions datagateway_api/src/search_api/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,8 @@
log = logging.getLogger()


# TODO - Make filters mandatory, if no filters are in a request an empty list will be
# given to these functions
@client_manager
def get_search(endpoint_name, entity_name, filters=list()):
def get_search(endpoint_name, entity_name, filters):
log.debug("Entity Name: %s, Filters: %s", entity_name, filters)

query = SearchAPIQuery(entity_name)
Expand All @@ -31,20 +29,20 @@ def get_search(endpoint_name, entity_name, filters=list()):


@client_manager
def get_with_id(endpoint_name, entity_name, id_, filters=None):
def get_with_id(endpoint_name, entity_name, id_, filters):
pass


@client_manager
def get_count(endpoint_name, entity_name, filters=None):
def get_count(endpoint_name, entity_name, filters):
pass


@client_manager
def get_files(endpoint_name, entity_name, filters=None):
def get_files(endpoint_name, entity_name, filters):
pass


@client_manager
def get_files_count(endpoint_name, entity_name, id_, filters=None):
def get_files_count(endpoint_name, entity_name, id_, filters):
pass

0 comments on commit b256eaf

Please sign in to comment.