Skip to content

Commit

Permalink
#163: Remove Python 3.4 from CI build
Browse files Browse the repository at this point in the history
  • Loading branch information
MRichards99 committed Jan 15, 2021
1 parent 8391a5c commit 9ebc58c
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ jobs:
runs-on: ubuntu-16.04
strategy:
matrix:
python-version: ['3.4.10', '3.5', '3.6', '3.7', '3.8', '3.9']
python-version: ['3.5', '3.6', '3.7', '3.8', '3.9']
name: Python ${{ matrix.python-version }} Build
steps:
- name: Add apt repo
Expand Down
8 changes: 7 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,17 +90,23 @@ development environment for this repo. This stage might take some time as each P
version needs to be downloaded and built individually:

```bash
pyenv install 3.4.10
pyenv install 3.5.10
pyenv install 3.6.8
pyenv install 3.7.7
pyenv install 3.8.2
pyenv install 3.9.0
```

To verify the installation commands worked:

```bash
python3.4 --version
python3.5 --version
python3.6 --version
python3.7 --version
python3.8 --version
python3.9 --version
```

These Python versions need to be made available to local version of the repository. They
Expand All @@ -109,7 +115,7 @@ following command will create a `.python-version` file inside the repo (this fil
currently listed in `.gitignore`):

```bash
pyenv local 3.6.8 3.7.7 3.8.2
pyenv local 3.4.10 3.5.10 3.6.8 3.7.7 3.8.2 3.9.0
```


Expand Down
2 changes: 1 addition & 1 deletion noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def safety(session):
session.log("Error: The temporary requirements file could not be closed")


@nox.session(python=["3.4", "3.5", "3.6", "3.7", "3.8", "3.9"], reuse_venv=True)
@nox.session(python=["3.5", "3.6", "3.7", "3.8", "3.9"], reuse_venv=True)
def tests(session):
args = session.posargs
session.run("poetry", "install", external=True)
Expand Down

0 comments on commit 9ebc58c

Please sign in to comment.