#135: Allow users to logout from Python ICAT backend

ral-facilities · Jun 24, 2020 · 8ca17eb · 8ca17eb
1 parent dbe8ba1
commit 8ca17eb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/common/python_icat_backend.py b/common/python_icat_backend.py
@@ -5,7 +5,7 @@
 
 from common.backend import Backend
 from common.helpers import queries_records
-from common.python_icat_helpers import requires_session_id, get_session_details_helper
+from common.python_icat_helpers import requires_session_id, get_session_details_helper, logout_icat_client
 from common.config import config
 from common.exceptions import AuthenticationError
 from common.models.db_models import SESSION
@@ -43,7 +43,8 @@ def refresh(self, session_id):
     @requires_session_id
     @queries_records
     def logout(self, session_id):
-        pass
+        self.client.sessionId = session_id
+        return logout_icat_client(self.client)
 
     @requires_session_id
     @queries_records

diff --git a/common/python_icat_helpers.py b/common/python_icat_helpers.py
@@ -55,3 +55,7 @@ def get_session_details_helper(client):
     username = client.getUserName()
 
     return {"ID": client.sessionId, "EXPIREDATETIME": str(session_expiry_time), "USERNAME": username}
+
+
+def logout_icat_client(client):
+    client.logout()