fix: #444 Generate publication dates between two specific dates

- This should stop relative generation causing different data to be generated on different days

util/icat_db_generator.py

@@ -673,7 +673,10 @@ def generate_data_publication(self, i):
         data_publication.title = faker.text()
         data_publication.description = faker.text()
         data_publication.pid = faker.isbn10(separator="-")
-        data_publication.publicationDate = faker.date_between(start_date="-15y")
+        data_publication.publicationDate = faker.date_between(
+            start_date=datetime.datetime(2008, 1, 1),
+            end_date=datetime.datetime(2023, 1, 1),
+        )
         data_publication.subject = faker.words()
         data_publication.facility = self.client.get("Facility", 1)
         data_publication.content = self.client.get(
@@ -725,8 +728,10 @@ def generate_data_publication_date(self, i):
                 "Valid",
             ),
         )
-        data_publication_date.date = faker.date_between(start_date="-15y")
         data_publication_date.publication = self.client.get("DataPublication", i)
+        data_publication_date.date = (
+            data_publication_date.publication.publicationDate.date()
+        )
         data_publication_date.create()