test: add tests for search API error signalling #296

test/search_api/test_error_handling.py

@@ -0,0 +1,42 @@
+import pytest
+
+from datagateway_api.src.common.exceptions import (
+    BadRequestError,
+    FilterError,
+    MissingRecordError,
+    SearchAPIError,
+)
+from datagateway_api.src.search_api.helpers import search_api_error_handling
+
+
+class TestErrorHandling:
+    @pytest.mark.parametrize(
+        "raised_exception, expected_exception, status_code",
+        [
+            pytest.param(BadRequestError, BadRequestError, 400, id="Bad request error"),
+            pytest.param(FilterError, FilterError, 400, id="Invalid filter"),
+            pytest.param(
+                MissingRecordError, MissingRecordError, 404, id="Missing record",
+            ),
+            pytest.param(SearchAPIError, SearchAPIError, 500, id="Search API error"),
+            pytest.param(TypeError, BadRequestError, 400, id="Type error"),
+            pytest.param(ValueError, BadRequestError, 400, id="Value error"),
+            pytest.param(AttributeError, BadRequestError, 400, id="Attribute error"),
+        ],
+    )
+    def test_valid_error_raised(
+        self, raised_exception, expected_exception, status_code,
+    ):
+        @search_api_error_handling
+        def raise_exception():
+            raise raised_exception()
+
+        try:
+            raise_exception()
+        except Exception as e:
+            assert isinstance(e.args[0], dict)
+            assert e.status_code == status_code
+            assert list(e.args[0]["error"].keys()) == ["statusCode", "name", "message"]
+
+        with pytest.raises(expected_exception):
+            raise_exception()