#150: Remove planning comments made at start of branch

ral-facilities · Nov 30, 2020 · 2c37baa · 2c37baa
1 parent e85f378
commit 2c37baa
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 10 deletions.
diff --git a/test/test_base.py b/test/test_base.py
@@ -3,8 +3,6 @@
 from datagateway_api.src.main import app
 
 
-# Move this into the test defintions and let it be inherited in test classes that need
-# it
 class FlaskAppTest(TestCase):
     """
     The FlaskAppTest Base class sets up a test client to be used to mock requests

diff --git a/test/test_database_helpers.py b/test/test_database_helpers.py
@@ -31,8 +31,6 @@
     )
 
 
-# Common across both, needs parameterized tests for different cased names, need multiple
-# tests for each filter
 class TestQueryFilterFactory(TestCase):
     def test_order_filter(self):
         self.assertIs(

diff --git a/test/test_entityHelper.py b/test/test_entityHelper.py
@@ -9,7 +9,6 @@
 )
 
 
-# DB only tests
 class TestEntityHelper(TestCase):
     def setUp(self):
         self.dataset = DATASET()

diff --git a/test/test_helpers.py b/test/test_helpers.py
@@ -30,7 +30,6 @@
 from test.test_base import FlaskAppTest
 
 
-# Put this in test definitions, but do tests there, don't abstract out
 class TestIsValidJSON(TestCase):
     def test_array(self):
         self.assertTrue(is_valid_json("[]"))
@@ -57,7 +56,6 @@ def test_list(self):
         self.assertFalse(is_valid_json([]))
 
 
-# Common for both backends, setup and teardown will be different
 class TestRequiresSessionID(FlaskAppTest):
     def setUp(self):
         super().setUp()
@@ -100,7 +98,6 @@ def test_good_credentials(self):
         )
 
 
-# Common across both, no need to abstract out
 class TestQueriesRecords(TestCase):
     def test_missing_record_error(self):
         @queries_records
@@ -168,7 +165,6 @@ def raise_bad_request_error():
         self.assertEqual(400, ctx.exception.status_code)
 
 
-# Common across both, no need to abstract out
 class TestGetSessionIDFromAuthHeader(FlaskAppTest):
     def test_no_session_in_header(self):
         with self.app:
@@ -186,7 +182,6 @@ def test_with_good_header(self):
             self.assertEqual("test", get_session_id_from_auth_header())
 
 
-# Common across both, needs abstracting out, class per filter, multiple tests per filter
 class TestGetFiltersFromQueryString(FlaskAppTest):
     def test_no_filters(self):
         with self.app: