Skip to content

Commit

Permalink
refactor: remove to_icat() functions #264
Browse files Browse the repository at this point in the history
  • Loading branch information
Viktor Bozhinov committed Dec 8, 2021
1 parent f2f0826 commit 2753e6e
Showing 1 changed file with 1 addition and 35 deletions.
36 changes: 1 addition & 35 deletions datagateway_api/src/search_api/models.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from abc import ABC, abstractclassmethod, abstractmethod
from abc import ABC, abstractclassmethod
from datetime import datetime
from decimal import Decimal
from typing import List, Optional, Union
Expand All @@ -19,10 +19,6 @@ class PaNOSCAttribute(ABC, BaseModel):
def from_icat(self):
pass

@abstractmethod
def to_icat(self):
pass


class Affiliation(PaNOSCAttribute):
"""Information about which facility a member is located at"""
Expand All @@ -39,9 +35,6 @@ class Affiliation(PaNOSCAttribute):
def from_icat(cls):
pass

def to_icat(self):
pass


class Dataset(PaNOSCAttribute):
"""
Expand All @@ -66,9 +59,6 @@ class Dataset(PaNOSCAttribute):
def from_icat(cls):
pass

def to_icat(self):
pass


class Document(PaNOSCAttribute):
"""
Expand Down Expand Up @@ -96,9 +86,6 @@ class Document(PaNOSCAttribute):
def from_icat(cls):
pass

def to_icat(self):
pass


class File(PaNOSCAttribute):
"""Name of file and optionally location"""
Expand All @@ -114,9 +101,6 @@ class File(PaNOSCAttribute):
def from_icat(cls):
pass

def to_icat(self):
pass


class Instrument(PaNOSCAttribute):
"""Beam line where experiment took place"""
Expand All @@ -132,9 +116,6 @@ class Instrument(PaNOSCAttribute):
def from_icat(cls):
pass

def to_icat(self):
pass


class Member(PaNOSCAttribute):
"""Proposal team member or paper co-author"""
Expand All @@ -151,9 +132,6 @@ class Member(PaNOSCAttribute):
def from_icat(cls):
pass

def to_icat(self):
pass


class Parameter(PaNOSCAttribute):
"""
Expand Down Expand Up @@ -185,9 +163,6 @@ def validate_dataset_and_document(cls, value, values): # noqa: B902, N805
def from_icat(cls):
pass

def to_icat(self):
pass


class Person(PaNOSCAttribute):
"""Human who carried out experiment"""
Expand All @@ -207,9 +182,6 @@ class Person(PaNOSCAttribute):
def from_icat(cls):
pass

def to_icat(self):
pass


class Sample(PaNOSCAttribute):
"""Extract of material used in the experiment"""
Expand All @@ -225,9 +197,6 @@ class Sample(PaNOSCAttribute):
def from_icat(cls):
pass

def to_icat(self):
pass


class Technique(PaNOSCAttribute):
"""Common name of scientific method used"""
Expand All @@ -241,9 +210,6 @@ class Technique(PaNOSCAttribute):
def from_icat(cls):
pass

def to_icat(self):
pass


# The below models reference other models that may not be defined during their
# creation so their references have to manually be updated to lead to the actual
Expand Down

0 comments on commit 2753e6e

Please sign in to comment.