refactor: refactor _get_icat_field_value logic #265

ral-facilities · Jan 28, 2022 · 1d730d1 · 1d730d1
1 parent 3f1b1cf
commit 1d730d1
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/datagateway_api/src/search_api/models.py b/datagateway_api/src/search_api/models.py
@@ -18,14 +18,10 @@ def _get_icat_field_value(icat_field_name, icat_data):
             values = []
             for data in icat_data:
                 value = _get_icat_field_value(field_name, data)
-                if isinstance(value, list):
-                    values.extend(value)
-                else:
-                    values.append(value)
-
+                value = [value] if not isinstance(value, list) else value
+                values.extend(value)
             icat_data = values
-
-        if isinstance(icat_data, dict):
+        elif isinstance(icat_data, dict):
             icat_data = icat_data[field_name]
 
     return icat_data