Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple assets #71

Closed
wants to merge 3 commits into from
Closed

Support multiple assets #71

wants to merge 3 commits into from

Conversation

shumon84
Copy link
Contributor

Support multiple assets by changing type of zipData from simple string to map [string] string.

@jcchavezs
Copy link
Collaborator

Thanks @shumon84 what about adding some unit tests on this one?

@shumon84
Copy link
Contributor Author

Thanks for quick reply.
I will add unit tests as you said.

@shumon84
Copy link
Contributor Author

@jcchavezs I added unit tests to fs_test.go

@jcchavezs
Copy link
Collaborator

jcchavezs commented Oct 22, 2019 •
edited
Loading

Sorry for the late response. Does it make sense to call it namespace instead of name? What do you think? After that I am ready to merge.

@shumon84
Copy link
Contributor Author

I agree with you.

@shumon84 shumon84 closed this Oct 22, 2019
@shumon84 shumon84 mentioned this pull request Oct 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shumon84 @jcchavezs