Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Idx assignment. Old code used range that makes a copy #6

Merged
merged 2 commits into from
Jan 18, 2018
Merged

fix Idx assignment. Old code used range that makes a copy #6

merged 2 commits into from
Jan 18, 2018

Conversation

rakelkar
Copy link
Owner

@rakelkar rakelkar commented Jan 18, 2018 •
edited
Loading

GetInterfaces: Fix merge logic
GetInterfaces: Add test for merge logic

@rakelkar rakelkar requested a review from jroggeman January 18, 2018 03:16
@rakelkar rakelkar mentioned this pull request Jan 18, 2018
Closed
jroggeman
jroggeman approved these changes Jan 18, 2018
View reviewed changes
Copy link
Collaborator

@jroggeman jroggeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is good, need to revisit code to figure out what necessary for unit testing. Will pair with you to get tests written

@rakelkar rakelkar merged commit 758b1f7 into master Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jroggeman jroggeman jroggeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rakelkar @jroggeman