Switch to Go modules #14
Conversation
|
@rakelkar could you enable Github actions in this repo so the tests can run? |
|
Hey Antonio - thanks for your PR - quick qn, did you try to get your changes in go-powershell updated to benmoss repo? |
|
@rakelkar I wasn't planning on doing it, since |
|
Would be great if you can try to get an okay from benmoss him as a curtsy :) |
|
have enabled actions btw! |
|
I have opened the PR: benmoss/go-powershell#1 If it's accepted, I'll update this PR. Looks like there are some unit tests failures, so I'll address them as well at that time. |
|
I got my answer: benmoss/go-powershell#1 (comment). He recommends switching to a different fork. |
* Switch to Go modules and remove vendoring * Use different fork of go-powershell: replace the current go-powershell dependency with https://github.com/antoninbas/go-powershell. This fork converts the project to Go modules and removes the dependency on juju packages (which are distributed under an LGPL v3 license, making usage in commercial products difficult) * Enable CI: run unit tests using Github workflows Fixes rakelkar#13
24ebd0a to
bea4a49
Compare
bea4a49 to
423d24b
Compare
|
@rakelkar I rebased the PR and fix the test failures. By the way, do you have any insight about the difference between this package and the upstream K8s one: https://github.com/kubernetes/kubernetes/tree/master/pkg/util/netsh? |
Actually there is no equivalent to https://github.com/rakelkar/gonetsh/tree/master/netroute in upstream K8s |
|
@rakelkar friendly ping for this |
dependency with https://github.com/antoninbas/go-powershell. This fork
converts the project to Go modules and removes the dependency on juju
packages (which are distributed under an LGPL v3 license, making usage
in commercial products difficult)
Fixes #13