-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace gorillalabs/go-powershell with bhendo/go-powershell #10
Conversation
They are indeed the same, can you update the vendored folder as well? |
It appears that the repository at https://github.com/gorillalabs/go-powershell/ no longer exists and has been moved to https://github.com/bhendo/go-powershell Authored-by: Todd Sedano <tsedano@pivotal.io>
c30cb15
to
e2d73c7
Compare
@rakelkar --- I made the change you suggested. Thanks in advance for merging this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this change! lgtm
whoops mv is not enough... you have to clone the new repo into vendor...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vendor is broken - please clone the new repo in
Authored-by: Todd Sedano <tsedano@pivotal.io>
Thanks. There's a new commit that updates the references. BTW, you need to run the build.ps1 file which downloads the dependencies.
For example, on master, when I do a On this branch, if I execute these commands, this works fine:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for this change!
It appears that the repository at https://github.com/gorillalabs/go-powershell/
no longer exists and has been moved to https://github.com/bhendo/go-powershell
I did a diff of the two repos and they are the same
Authored-by: Todd Sedano tsedano@pivotal.io