Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace gorillalabs/go-powershell with bhendo/go-powershell #10

Merged
merged 2 commits into from
Jul 19, 2019

Conversation

professor
Copy link
Contributor

It appears that the repository at https://github.com/gorillalabs/go-powershell/
no longer exists and has been moved to https://github.com/bhendo/go-powershell

I did a diff of the two repos and they are the same

Authored-by: Todd Sedano tsedano@pivotal.io

@rakelkar
Copy link
Owner

They are indeed the same, can you update the vendored folder as well?

It appears that the repository at https://github.com/gorillalabs/go-powershell/
no longer exists and has been moved to https://github.com/bhendo/go-powershell

Authored-by: Todd Sedano <tsedano@pivotal.io>
@professor professor force-pushed the replace-go-powershell branch from c30cb15 to e2d73c7 Compare July 17, 2019 22:27
@professor
Copy link
Contributor Author

@rakelkar --- I made the change you suggested. Thanks in advance for merging this PR.

Copy link
Owner

@rakelkar rakelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change! lgtm

@rakelkar
Copy link
Owner

whoops mv is not enough... you have to clone the new repo into vendor...

e:\go\src\github.com\rakelkar\gonetsh (replace-go-powershell)
λ go build -v ./...
vendor\bhendo\go-powershell\shell.go:11:2: cannot find package "github.com/gorillalabs/go-powershell/backend" in any of:
        C:\Go\src\github.com\gorillalabs\go-powershell\backend (from $GOROOT)
        C:\Users\rakelkar\go\src\github.com\gorillalabs\go-powershell\backend (from $GOPATH)
vendor\bhendo\go-powershell\shell.go:12:2: cannot find package "github.com/gorillalabs/go-powershell/utils" in any of:
        C:\Go\src\github.com\gorillalabs\go-powershell\utils (from $GOROOT)
        C:\Users\rakelkar\go\src\github.com\gorillalabs\go-powershell\utils (from $GOPATH)

Copy link
Owner

@rakelkar rakelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vendor is broken - please clone the new repo in

Authored-by: Todd Sedano <tsedano@pivotal.io>
@professor
Copy link
Contributor Author

Thanks. There's a new commit that updates the references.

BTW, you need to run the build.ps1 file which downloads the dependencies.

go get ./...
go build -v ./...

For example, on master, when I do a go build -v ./... there are many packages that I need to go get...
netroute/netroute.go:10:2: cannot find package "github.com/gorillalabs/go-powershell" in any of:
/usr/local/Cellar/go/1.12.1/libexec/src/github.com/gorillalabs/go-powershell (from $GOROOT)
/Users/pivotal/go/src/github.com/gorillalabs/go-powershell (from $GOPATH)
netroute/netroute.go:11:2: cannot find package "github.com/gorillalabs/go-powershell/backend" in any of:
/usr/local/Cellar/go/1.12.1/libexec/src/github.com/gorillalabs/go-powershell/backend (from $GOROOT)
/Users/pivotal/go/src/github.com/gorillalabs/go-powershell/backend (from $GOPATH)
netsh/netsh.go:12:2: cannot find package "k8s.io/utils/exec" in any of:
/usr/local/Cellar/go/1.12.1/libexec/src/k8s.io/utils/exec (from $GOROOT)
/Users/pivotal/go/src/k8s.io/utils/exec (from $GOPATH)
netsh/testing/fake_netsh.go:20:2: cannot find package "github.com/rakelkar/gonetsh/netsh" in any of:
/usr/local/Cellar/go/1.12.1/libexec/src/github.com/rakelkar/gonetsh/netsh (from $GOROOT)
/Users/pivotal/go/src/github.com/rakelkar/gonetsh/netsh (from $GOPATH)

On this branch, if I execute these commands, this works fine:

go get ./...
go build -v ./...

Copy link
Owner

@rakelkar rakelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this change!

@rakelkar rakelkar merged commit 501daad into rakelkar:master Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants