Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating the documentation for v6 #2983

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Updating the documentation for v6 #2983

merged 1 commit into from
Apr 22, 2021

Conversation

guillaumebriday
Copy link
Member

No description provided.

@gauravtiwari gauravtiwari merged commit 49317a4 into rails:master Apr 22, 2021
@rromanchuk
Copy link

this is really great, thanks. The changes in v6, even just naming defaults, has really made a difference helping a non-js person like myself hit the ground running.

@guillaumebriday
Copy link
Member Author

thanks @rromanchuk 🙏

@rromanchuk
Copy link

Just found minor config issue when moving to non local environment. I moved to app/packs right away since app/javascripts is a mental mouse trap for rails people. I just forgot about autoloading for Zeitwerk, since i've moved off the rails new defaults, my packs folder was being picked up. Just gave it my new webpacker path to ignore.

Rails.autoloaders.main.ignore(Rails.root.join('app/packs'))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauravtiwari gauravtiwari Awaiting requested review from gauravtiwari

@jakeNiemiec jakeNiemiec Awaiting requested review from jakeNiemiec

@rossta rossta Awaiting requested review from rossta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guillaumebriday @rromanchuk @gauravtiwari