Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog #253

Merged
merged 2 commits into from
Apr 11, 2017
Merged

Add changelog #253

merged 2 commits into from
Apr 11, 2017

Conversation

gauravtiwari
Copy link
Member

Related to #211

@dhh Please review this when you get a chance.

@gauravtiwari gauravtiwari merged commit f612899 into rails:master Apr 11, 2017
@gauravtiwari gauravtiwari deleted the add-changelog branch April 11, 2017 12:01
@rafaelfranca
Copy link
Member

We avoid to add a CHANGELOG in the rails repositories because it became a maintenance pain. What about instead of using a CHANGELOG file in the repository we use the releases page of the repository like sass-rails and globalid do?

```

### Added (breaking changes)
- Static assets support - [#153](https://github.com/rails/webpacker/pull/153)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it was a breaking change why released it under 1.1? I guess we released the 1.0 too early.

Copy link
Member Author

@gauravtiwari gauravtiwari Apr 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yepp we released 1.0 in Feb and 1.1 was released just after the static support was merged. Perhaps, because we were experimenting with many things and it wasn't very clear.

@gauravtiwari
Copy link
Member Author

@rafaelfranca Yes, that makes sense and what you suggested sounds like a great idea. Since, webpacker got releases too, we can do the same as sass-rails 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants