Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI not running clean #781

Closed
timdiggins opened this issue Mar 4, 2022 · 1 comment · Fixed by #789
Closed

CI not running clean #781

timdiggins opened this issue Mar 4, 2022 · 1 comment · Fixed by #789

Comments

@timdiggins
Copy link
Contributor

🌈 CI seems to be not running clean because of:

There's a combination PR #780 if you prefer a simple one-shot to get to green.
@dorner
Copy link

dorner commented Mar 4, 2022

I think the combo PR looks fine! @rafaelfranca

timdiggins added a commit to timdiggins/thor that referenced this issue Mar 4, 2022
@timdiggins
First fix CI so it's green (see rails#780, rails#781)
3da3b44 
fix options spec.

allow line_editor spec to be run independently

running `rspec spec/line_editor_spec.rb` generated a double error
when it tries to re require "readline"

fix expectations for ruby 3 treatment of hash arg

try coveralls_reborn to fix ssl errors.

Note that we could also use the coveralls action as recommended
in https://github.com/tagliala/coveralls-ruby-reborn
but it seems like a github token is needed, which makes
it more complex for contributors

This does mean dropping coveralls for EOLed rubies but
do we really need to post to coveralls on each test run?
Wouldn't one test run be enough?
This was referenced Mar 11, 2022
Closed
Closed
Closed
@deivid-rodriguez deivid-rodriguez mentioned this issue Jun 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Ruby 3.2.0-dev CI deivid-rodriguez/thor
2 participants
@timdiggins @dorner