Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Source Map Preprocessor #206

Merged
merged 1 commit into from
Jan 7, 2016

Conversation

schneems
Copy link
Member

An alternative to #205 we don't set any sort of a "default" source map if one is already provided via another preprocessor like coffee or sass. We also set the default to be a line for line match between original and generated.

I'm not sure why the url for babel is different test is different in test_source_maps.rb#111 and test_source_maps.rb#161, or how we lost the digest on test_source_maps.rb#L119.

Thanks for some implementation ideas in: 9e119cd

An alternative to #205 we don't set any sort of a "default" source map if one is already provided via another preprocessor like coffee or sass. We also set the default to be a line for line match between original and generated. 

I'm not sure why the url for babel is different test is different in `test_source_maps.rb#111` and `test_source_maps.rb#161`, or how we lost the digest on `test_source_maps.rb#L119`.

Thanks for some implementation ideas in: 9e119cd
schneems added a commit that referenced this pull request Jan 7, 2016
@schneems schneems merged commit a0cd801 into master Jan 7, 2016
@elia
Copy link
Contributor

elia commented Jan 7, 2016

👍

@lucasmazza
Copy link
Contributor

@schneems any ideas on how this patch might affect the //= require processing? I'm getting some Sprockets::FileNotFound on //= requires that are pointing to assets with different extensions, like when you require normalize.css inside application.scss, while same extension requires (scss to scss) are working as usual.

//= require normalize/normalize.css
@import 'foo/bar';

The same issue happens when requiring a .js file inside an .es6 asset. I couldn't figure out why this might be happening based on the diff here but I tested against the previous commit (723c94c) and the pipeline works as expected.

@schneems
Copy link
Member Author

IDK, can you give me an example app?

@lucasmazza
Copy link
Contributor

@schneems I'll see if I can isolate it and replicate in a new app

@jeremy jeremy deleted the schneems/default-sourcemap-preprocessor branch November 3, 2016 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants