Merge pull request #778 from eregon/run-all-tests-on-truffleruby

Remove skips on truffleruby, latest truffleruby passes the whole test suite [changelog skip]
rails · Feb 8, 2023 · 925fb65 · 925fb65
2 parents eafbd11 + 6690110
commit 925fb65
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/test/test_encoding_utils.rb b/test/test_encoding_utils.rb
@@ -52,7 +52,9 @@ def test_fail_to_unmarshal_older_major_version
   end
 
   def test_fail_to_unmarshal_not_enough_data
-    skip "TypeError on TruffleRuby" if RUBY_ENGINE == "truffleruby"
+    if RUBY_ENGINE == 'truffleruby' and Gem::Version.new(RUBY_ENGINE_VERSION) < Gem::Version.new('23.0.0.a')
+      skip "TypeError on TruffleRuby < 23.0"
+    end
 
     assert_raises ArgumentError do
       Marshal.load("")

diff --git a/test/test_erb_processor.rb b/test/test_erb_processor.rb
@@ -32,7 +32,9 @@ def test_compile_erb_template_that_depends_on_env
     old_env_value = ::ENV['ERB_ENV_TEST_VALUE']
     ::ENV['ERB_ENV_TEST_VALUE'] = 'success'
 
-    skip 'https://github.com/oracle/truffleruby/issues/2810' if RUBY_ENGINE == 'truffleruby'
+    if RUBY_ENGINE == 'truffleruby' and Gem::Version.new(RUBY_ENGINE_VERSION) < Gem::Version.new('23.0.0.a')
+      skip 'https://github.com/oracle/truffleruby/issues/2810'
+    end
 
     root = File.expand_path("../fixtures", __FILE__)
     environment = Sprockets::Environment.new(root)
@@ -58,7 +60,9 @@ def test_compile_erb_template_that_depends_on_env
   def test_compile_erb_template_that_depends_on_empty_env
     old_env_value = ::ENV.delete('ERB_ENV_TEST_VALUE')
 
-    skip 'https://github.com/oracle/truffleruby/issues/2810' if RUBY_ENGINE == 'truffleruby'
+    if RUBY_ENGINE == 'truffleruby' and Gem::Version.new(RUBY_ENGINE_VERSION) < Gem::Version.new('23.0.0.a')
+      skip 'https://github.com/oracle/truffleruby/issues/2810'
+    end
 
     root = File.expand_path("../fixtures", __FILE__)
     environment = Sprockets::Environment.new(root)