Version the gem's helpers; if they change, the cache must go #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,5 @@ | |||
| module Sprockets | |||
There was a problem hiding this comment.
I guess we should require this file on sprockets/rails.rb, right?
|
|
| @@ -4,6 +4,7 @@ | |||
| require 'active_support/core_ext/module/remove_method' | |||
| require 'sprockets' | |||
| require 'sprockets/rails/helper' | |||
| require 'sprockets/rails/version' | |||
There was a problem hiding this comment.
Better to move to lib/sprockets/rails because we don't require this file if Railtie is not defined.
To do so cleanly, fix the fact we don't have a VERSION constant.
rafaelfranca
added a commit
that referenced
this pull request
Apr 9, 2014
Version the gem's helpers; if they change, the cache must go
rafaelfranca
added a commit
that referenced
this pull request
Apr 9, 2014
Version the gem's helpers; if they change, the cache must go Conflicts: sprockets-rails.gemspec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sprockets incorporates its own version into the digest, so any update will clear the cache; we should follow suit.