Rails 7.1 support #104
Merged
Rails 7.1 support #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
631dba4 to
0637499
Compare
This is the same fix of rails/rails#49716 but applied to SolidCache Store.
bcce38a to
ff1700b
Compare
- Support for multiple Rails version in CI via appraisal - Fix tests to work with multiple Rails versions
djmb
reviewed
Nov 16, 2023
| @@ -0,0 +1,35 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| module CacheStoreFormatVersionBehavior | |||
There was a problem hiding this comment.
There look to be some more tests in https://github.com/rails/rails/blob/main/activesupport/test/cache/behaviors/cache_store_format_version_behavior.rb. Could we pull those in as well?
There was a problem hiding this comment.
Good point, handled in 2c578d7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internal_exec_queryto not clear the query cache after 7.1.