-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for after_create_commit, after_update_commit and after_destroy_commit #66
base: master
Are you sure you want to change the base?
Conversation
…stroy_commit. These were added in Rails 5 as aliases for using after_commit callback only on create, update or delete.
Any progress on merging this? |
Can we have tests to cover this? |
I'll take care of this. |
@bhalash any progress on this? Thanks |
@GContaldi Sorry, it turns out that I've been rather busy lately. I hope to have time to tackle it before the end of this week. |
@bhalash thanks a lot for the prompt response :) |
@GContaldi Update: I'm resource constrained in my job (sole developer), but we've slated time for next week to get this done. Busy busy. -_- |
Any progress on this? From reading the comments it seems it has been over a year. I am currently in need of these callbacks supported for observers after upgrading to Rails 5. Thanks. |
@nrvakil I haven't worked with Rails since May. The developers (pinging @GContaldi and @rafaelfranca ) have not responded to this pull request for whatever reason. ¯\_(ツ)_/¯ You are free to pull it and update the PR yourself, sorry man! |
This is a follow up to #50. These three callbacks were added in Rails 5 as aliases for using after_commit callback only on create, update or delete. Thus they are not actually part of ActiveRecord::Callbacks::CALLBACKS but instead are defined active_record/transactions.rb