Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for after_create_commit, after_update_commit and after_destroy_commit #66

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cfis
Copy link

@cfis cfis commented Oct 9, 2017

This is a follow up to #50. These three callbacks were added in Rails 5 as aliases for using after_commit callback only on create, update or delete. Thus they are not actually part of ActiveRecord::Callbacks::CALLBACKS but instead are defined active_record/transactions.rb

…stroy_commit. These were added in Rails 5 as aliases for using after_commit callback only on create, update or delete.
@bhalash
Copy link

bhalash commented Oct 21, 2017

Any progress on merging this?

@rafaelfranca
Copy link
Member

Can we have tests to cover this?

@bhalash
Copy link

bhalash commented Oct 26, 2017

I'll take care of this.

@GContaldi
Copy link

@bhalash any progress on this? Thanks

@bhalash
Copy link

bhalash commented Nov 21, 2017

@GContaldi Sorry, it turns out that I've been rather busy lately. I hope to have time to tackle it before the end of this week.

@GContaldi
Copy link

@bhalash thanks a lot for the prompt response :)

@bhalash
Copy link

bhalash commented Nov 28, 2017

@GContaldi Update: I'm resource constrained in my job (sole developer), but we've slated time for next week to get this done. Busy busy. -_-

@nrvakil
Copy link

nrvakil commented Nov 15, 2018

Any progress on this? From reading the comments it seems it has been over a year. I am currently in need of these callbacks supported for observers after upgrading to Rails 5. Thanks.

@bhalash
Copy link

bhalash commented Nov 15, 2018

@nrvakil I haven't worked with Rails since May. The developers (pinging @GContaldi and @rafaelfranca ) have not responded to this pull request for whatever reason. ¯\_(ツ)_/¯

You are free to pull it and update the PR yourself, sorry man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants