Do not digest already digested files

[brenogazzola]

@dhh Not sure how you will prefer to handle this one:

If I have an already digested file like trix_chunk-abcdef012345678.js in /build, then Asset will use the entire thing as the logical_path, but Server will only pass to LoadPath the string trix_chunk.js. Either Asset or LoadPath have to strip the digest too. Which do you prefer?

[dhh]

I'm concerned that -([0-9a-f]{7,128}) will pickup things like javascript-somethingabovesevencharacters.js and not digest. We actually have the same problem with the change made to Sprockets. I think it's good we didn't do a release there yet!

[brenogazzola]

Ok. How about instead of detecting the digest we detect a keyword in the name? Since we can control the file name through webpack, we could tell it to add something like -digested before or after the content hash and sprockets/propshaft would use that to skip digesting.

[dhh]

Yes, I think that's safer. Maybe something like lib-aw68as6wewq.digested.js?

[brenogazzola]

Ok, I'll submit a PR for Sprockets too.

[brenogazzola]

Did you mean we should detect .digested.js or -[digest].digested.js? 😅

[dhh]

I guess -[digest].digested.js is even safer. Highly unlikely to snare files you didn't intend to catch with this.

[brenogazzola]

Ok, done here. Will go back to jsbundling and sprockets to adjust. We still need the problem with Server stripping the digest. Guess that now that we have a keyword we can detect that and skip?

-- digest    = full_path[/-([0-9a-f]{7,128})\.[^.]+\z/, 1]
++ digest    = full_path[/-([0-9a-f]{7,128})\.(?!digested)[^.]+\z, 1]

[dhh]

Yes, can you do a PR with test for the server change?