dependencies: Update dependency ethers to v5 #2289
Conversation
|
|
fb35ac2 to
2764024
Compare
|
You modified |
2764024 to
dc1aa7b
Compare
|
Ok, I managed to get the SDK to build with ethers v5.
|
|
Some implementation suggestions: On SDK, in order to minimize code changes, I opted to import the named exports from the On dApp and CLI, I think it's not worth the weight of adding the individual namespaced packages, so we should use the types and exports from the import { BigNumber, ethers } from 'ethers';
const formated = ethers.utils.formatEther(BigNumber.from(10));i.e. accessing from the namespaced mapping object, in order to use utilities and even some types from the exported subpackages, specially from As already shown above, Please, let me know if there's any question. Thank you very much. |
|
Thank you very much @andrevmatos 🙏 Hmm, I think the package for the dApp is already huge. Also I do not like to use the namespace objects to much. 🤔 Btw: Does the |
|
Note for the careful reader: @palango his question was answered in a channel external of GitHub. |
We need to test. These packages should be imported from their (new) ESM build automatically by tools like webpack, so maybe it won't grow the package in any way more than using the namespaced packages. Notice also importing from the exports in
It shouldn't, because it's not |
Okay no, at least for the dApp this is configured as |
398de3e to
bb294e8
Compare
|
@agatsoh So I think I managed to fix tests fixtures and mocks. Most If |
287e0f4 to
42e7d76
Compare
Codecov Report
@@ Coverage Diff @@
## master #2289 +/- ##
==========================================
- Coverage 94.94% 94.80% -0.15%
==========================================
Files 156 156
Lines 6293 6294 +1
Branches 1166 1078 -88
==========================================
- Hits 5975 5967 -8
- Misses 253 262 +9
Partials 65 65
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
SDK tests are green. I'll investigate the dApp build errors tomorrow. They're caused by |
2076fe1 to
140ca4d
Compare
a4cc243 to
2d9ca28
Compare
|
I have tested it: transfers, channel open, close, deposit, UDC deposit, UDC withdraw, ETH subkey deposit.. everything seems to be working as expected. |
Allow me to answer for him: yes, atm this is an issue for some notifications. @taleldayekh was there an issue to add all missing icons? |
dcb9e21 to
ce704ab
Compare
There was a problem hiding this comment.
@andrevmatos thank you so much for all the work you have invested here! 🙏
I was prepared this morning to start to fully adopt the project from pnpm to yarn but you already did it. All the changes look good to me. 👍
Fixes #1707
Upgrades ethers to v5 and switch
pnpmforyarn workspaces, since pnpm had issues detecting and installing sub-dependencies of ethers v5.This PR contains the following updates:
^4.0.48->^5.0.19^4.0.48->^5.0.19Release Notes
ethers-io/ethers.js
v5.0.19Compare Source
v5.0.18Compare Source
v5.0.17Compare Source
v5.0.16Compare Source
v5.0.15Compare Source
v5.0.14Compare Source
v5.0.13Compare Source
v5.0.12Compare Source
v5.0.11Compare Source
v5.0.10Compare Source
v5.0.9Compare Source
v5.0.8Compare Source
v5.0.7Compare Source
v5.0.6Compare Source
v5.0.5Compare Source
v5.0.4Compare Source
v5.0.3Compare Source
v5.0.2Compare Source
v5.0.1Compare Source
v5.0.0Compare Source
Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by WhiteSource Renovate. View repository job log here.