Skip to content

Commit

Permalink
Fixes and new message for VW MQB, fix for Accord Touring (commaai#193)
Browse files Browse the repository at this point in the history 
* Update ACC_02.SetSpeed to use a more accurate m/s formula instead of kmh

* Fixes to LWI vs EPS calculations for steering angles, clarify descriptions of each.

* Endianness fixes

* Add ESP_15 and PSD_04/05/06

* Testing PSD interpretation

* Correct message info for ESP_08

* Additional authoritative message names and IDs

* OpenDBC updates

* OpenDBC updates

* DBC cleanup, CRC support, restore VIN_01 mux lost during Cabana editing.

* Add the PQ heading control assist message.

* OpenDBC updates

* Add a pointer to the VIN_1 mux.

* Probable EPS_1 message

* Add comment about rate-limiting on Getriebe_11 counter signal.

* Rename CRC->CHECKSUM for upstream of a minimum viable VW port.

Per my Discord talk with @rbiasini, to reduce OP core code diffs a bit, we will temporarily (ab)use CHECKSUM to store a CRC like Pedal is doing today. After the port is upstreamed, we will look at updating the core OP code to support dynamic CRC and counter signal names, and revert the DBC signal names back to canonical (MSG_NAME_CRC, MSG_NAME_BZ, etc). I will update the OP core CRC support PR shortly.

* OpenDBC updates

* OpenDBC updates

* Probable EPS_1 message

* Updates for Volkswagen support (commaai#191)

* Update ACC_02.SetSpeed to use a more accurate m/s formula instead of kmh

* Fixes to LWI vs EPS calculations for steering angles, clarify descriptions of each.

* Endianness fixes

* Add ESP_15 and PSD_04/05/06

* Testing PSD interpretation

* Correct message info for ESP_08

* Additional authoritative message names and IDs

* OpenDBC updates

* OpenDBC updates

* DBC cleanup, CRC support, restore VIN_01 mux lost during Cabana editing.

* Add the PQ heading control assist message.

* Add a pointer to the VIN_1 mux.

* Add comment about rate-limiting on Getriebe_11 counter signal.

* Rename CRC->CHECKSUM for upstream of a minimum viable VW port.

Per my Discord talk with @rbiasini, to reduce OP core code diffs a bit, we will temporarily (ab)use CHECKSUM to store a CRC like Pedal is doing today. After the port is upstreamed, we will look at updating the core OP code to support dynamic CRC and counter signal names, and revert the DBC signal names back to canonical (MSG_NAME_CRC, MSG_NAME_BZ, etc). I will update the OP core CRC support PR shortly.

* Lexus is adjustment (commaai#192)

* Add 581 for ISH gas pedal signal

* Add STEER_ANGLE in 608 STEER_TORQUE_SENSOR (similar to TSS2)

* Change STEER_TORQUE_EPS factor in 608 STEER_TORQUE_SENSOR to 1.0

* Re-generate lexus_is_2018

* reduce factor to 0.77

* Fix steer angle factor for toyota

* OpenDBC updates

* Create luxgen_s5_2014.dbc (commaai#101)

* Create luxgen_s5_2015.dbc

* Update luxgen_s5_2015.dbc

* Update luxgen_s5_2015.dbc

* fixed to luxgen dbc file

* EV_Gearshift message

* EV_Gearshift message for e-Golf support without a separate gearbox.

* Corrected byte order on two signals.

* Corrected byte order on several homebrewed VW MQB signals.
  • Loading branch information
@jyoung8607 @rbiasini
jyoung8607 authored and rbiasini committed Oct 17, 2019
1 parent a09bf72 commit c516316
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 12 deletions.
4 changes: 2 additions & 2 deletions honda_accord_touring_2016_can.dbc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -177,14 +177,14 @@ BO_ 597 ROUGH_WHEEL_SPEED: 8 VSA
SG_ SET_TO_X55_2 : 47|8@0+ (1,0) [0|255] "" NEO
SG_ LONG_COUNTER : 55|8@0+ (1,0) [0|255] "" XXX
SG_ COUNTER : 61|2@0+ (1,0) [0|3] "" XXX
SG_ CHECKSUM : 59|4@1+ (1,0) [0|15] "" XXX
SG_ CHECKSUM : 59|4@0+ (1,0) [0|15] "" XXX

BO_ 660 SCM_COMMANDS: 8 SCM
SG_ RIGHT_BLINKER : 6|1@0+ (1,0) [0|1] "" NEO
SG_ LEFT_BLINKER : 5|1@0+ (1,0) [0|1] "" NEO
SG_ WIPERS_SPEED : 4|2@0+ (1,0) [0|3] "" NEO
SG_ COUNTER : 61|2@0+ (1,0) [0|3] "" XXX
SG_ CHECKSUM : 59|4@1+ (1,0) [0|15] "" XXX
SG_ CHECKSUM : 59|4@0+ (1,0) [0|15] "" XXX

BO_ 661 XXX_10: 4 XXX
SG_ COUNTER : 29|2@0+ (1,0) [0|3] "" XXX
Expand Down
27 changes: 17 additions & 10 deletions vw_mqb_2010.dbc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1196,14 +1196,14 @@ BO_ 159 EPS_01: 8 XXX
SG_ CHECKSUM : 0|8@1+ (1,0) [0|255] "" XXX
SG_ COUNTER : 8|4@1+ (1,0) [0|15] "" XXX
SG_ Steering_Wheel_Angle : 16|13@1+ (0.15,0) [0|16383] "Unit_DegreOfArc" XXX
SG_ Steering_Wheel_Angle_VZ : 31|1@0+ (1,0) [0|1] "" XXX
SG_ HCA_Active : 34|1@0+ (1,0) [0|1] "" XXX
SG_ HCA_Standby : 33|1@0+ (1,0) [0|1] "" XXX
SG_ Unknown_Status2 : 63|1@0+ (1,0) [0|1] "" XXX
SG_ Steering_Wheel_Angle_VZ : 31|1@1+ (1,0) [0|1] "" XXX
SG_ HCA_Active : 34|1@1+ (1,0) [0|1] "" XXX
SG_ HCA_Standby : 33|1@1+ (1,0) [0|1] "" XXX
SG_ Unknown_Status2 : 63|1@1+ (1,0) [0|1] "" XXX
SG_ HCA_Ready : 32|1@1+ (1,0) [0|3] "" XXX
SG_ Driver_Strain : 40|13@1+ (1,0) [0|255] "Nm" XXX
SG_ Driver_Strain_VZ : 55|1@1+ (1,0) [0|1] "" XXX
SG_ Unknown_Status1 : 62|1@0+ (1,0) [0|1] "" XXX
SG_ Unknown_Status1 : 62|1@1+ (1,0) [0|1] "" XXX

BO_ 286 VehicleSpeed: 8 XXX
SG_ VehicleSpeed_CRC : 0|8@1+ (1,0) [0|255] "" XXX
Expand All @@ -1213,13 +1213,13 @@ BO_ 286 VehicleSpeed: 8 XXX
BO_ 919 LDW_02: 8 XXX
SG_ LDW_DLC : 40|8@1+ (0.01,0) [0|255] "m" XXX
SG_ LDW_TLC : 48|5@1+ (0.05,0) [0|255] "Seconds" XXX
SG_ LDW_Unknown : 15|2@0+ (1,0) [0|3] "" XXX
SG_ LDW_Unknown : 14|2@1+ (1,0) [0|3] "" XXX
SG_ Alert_Message : 16|4@1+ (1,0) [0|15] "" XXX
SG_ LDW_Direction : 20|1@0+ (1,0) [0|1] "" XXX
SG_ LDW_Direction : 20|1@1+ (1,0) [0|1] "" XXX
SG_ Right_Lane_Status : 36|2@1+ (1,0) [0|3] "" XXX
SG_ Left_Lane_Status : 38|2@1+ (1,0) [0|3] "" XXX
SG_ Kombi_Lamp_Orange : 61|1@0+ (1,0) [0|1] "" XXX
SG_ Kombi_Lamp_Green : 62|1@0+ (1,0) [0|1] "" XXX
SG_ Kombi_Lamp_Orange : 61|1@1+ (1,0) [0|1] "" XXX
SG_ Kombi_Lamp_Green : 62|1@1+ (1,0) [0|1] "" XXX

BO_ 780 ACC_02: 8 XXX
SG_ CHECKSUM : 0|8@1+ (1,0) [0|255] "" XXX
Expand Down Expand Up @@ -1307,7 +1307,11 @@ BO_ 1646 Klima_03: 8 XXX

BO_ 1720 Kombi_03: 8 XXX


BO_ 391 EV_Gearshift: 8 XXX
SG_ CHECKSUM : 0|8@1+ (1,0) [0|255] "" XXX
SG_ COUNTER : 8|4@1+ (1,0) [0|15] "" XXX
SG_ GearPosition : 16|4@1+ (1,0) [0|255] "" XXX
SG_ RegenBrakingMode : 12|2@1+ (1,0) [0|3] "" XXX

CM_ SG_ 173 COUNTERXX "Message not renamed to COUNTER because J533 rate-limiting makes it look like messages are being lost"
CM_ SG_ 134 LWI_Lenkradwinkel "Steering angle WITH variable ratio effect included";
Expand All @@ -1334,4 +1338,7 @@ CM_ SG_ 780 Folgefahrt "Following another vehicle";
CM_ SG_ 780 SetAbstand "Set following distance";
CM_ SG_ 780 Abstand "Following distance";
CM_ SG_ 780 SetSpeed "ACC set speed";
CM_ SG_ 391 GearPosition "Traditional PRND plus B-mode aggressive regen, B-mode mapped to Drive";
VAL_ 173 GE_Fahrstufe 5 "P" 6 "R" 7 "N" 8 "D" 9 "S" 10 "E" 14 "T" ;
VAL_ 391 GearPosition 2 "P" 3 "R" 4 "N" 5 "D" 6 "D"
VAL_ 391 RegenBrakingMode 0 "default" 1 "B1" 2 "B2" 3 "B3"

0 comments on commit c516316

Please sign in to comment.