Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Makie in [weakdeps] to 0.22, (keep existing compat) #902

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Makie package from 0.20, 0.21 to 0.20, 0.21, 0.22.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@rafaqz rafaqz force-pushed the compathelper/new_version/2025-01-14-00-36-10-149-02142433071 branch from 84aef24 to 3f41ac9 Compare January 14, 2025 00:36
Copy link
Collaborator

@asinghvi17 asinghvi17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs fail because of a doctest failure and Makie's latest version fails to compile on nightly. Other than that this seems fine, so I'd say let's merge and release!

@asinghvi17 asinghvi17 requested a review from rafaqz January 22, 2025 01:47
@rafaqz rafaqz merged commit 10e2877 into main Jan 22, 2025
6 of 8 checks passed
@rafaqz rafaqz deleted the compathelper/new_version/2025-01-14-00-36-10-149-02142433071 branch January 25, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants