Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Date in Near #598

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Use Date in Near #598

merged 3 commits into from
Jan 30, 2024

Conversation

rafaqz
Copy link
Owner

@rafaqz rafaqz commented Jan 30, 2024

Fixes #589

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d417e36) 87.29% compared to head (d24c40c) 87.25%.
Report is 3 commits behind head on main.

Files Patch % Lines
src/array/show.jl 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #598      +/-   ##
==========================================
- Coverage   87.29%   87.25%   -0.05%     
==========================================
  Files          43       43              
  Lines        3448     3491      +43     
==========================================
+ Hits         3010     3046      +36     
- Misses        438      445       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafaqz rafaqz merged commit b9298af into main Jan 30, 2024
10 of 11 checks passed
@rafaqz rafaqz deleted the near_date branch January 30, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subsetting time axis with DateTime using Near(Date(...)) fails
2 participants