fix: make libcheck fatal if missing with --with-check #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stappersg
reviewed
Jan 22, 2025
|
Complicated but this is the "correct" autoconf way to do it. |
|
On Wed, Jan 22, 2025 at 11:45:45AM -0800, Robin H. Johnson wrote:
Complicated but this is the "correct" autoconf way to do it.
Please add that insight to the commit message.
Groeten
Geert Stappers
Doesn't like single line commit messages.
--
Silence is hard to parse
|
Without this, trying to run `make check` after `configure --without-check` fails to link: `undefined reference to `srunner_create'` Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
9b9f173 to
6434c57
Compare
More details in the commit now |
|
Strange:
|
|
|
On Thu, Jan 23, 2025 at 01:05:34PM -0800, Robin H. Johnson wrote:
> Strange:
You do have the `write` permission already
Ah, I see. And I will have a closer look when the oppurtunity rises.
Groeten
Geert Stappers
--
Silence is hard to parse
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, trying to run
make checkafterconfigure --without-checkfails to link:undefined reference tosrunner_create'`Signed-off-by: Robin H. Johnson robbat2@gentoo.org