Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make failed when go 1.16.6 #139

Closed
andyli029 opened this issue Jul 14, 2021 · 1 comment · Fixed by #141
Closed

make failed when go 1.16.6 #139

andyli029 opened this issue Jul 14, 2021 · 1 comment · Fixed by #141
Assignees
@andyli029
Labels
bug Something isn't working P0 High priority
Milestone
v2.0.0

Comments

@andyli029
Copy link
Contributor

andyli029 commented Jul 14, 2021 •
edited
Loading

Describe the problem
make failed when go 1.16.6

To Reproduce

#make vet
go vet ./...
# github.com/radondb/radondb-mysql-kubernetes/utils
utils/unsafe.go:33:35: possible misuse of reflect.StringHeader
utils/unsafe.go:45:35: possible misuse of reflect.SliceHeader
make: *** [vet] Error 2

Expected behavior

#make vet
go vet ./...

Environment:

  • RadonDB MySQL version:
@andyli029 andyli029 added the bug Something isn't working label Jul 14, 2021
@andyli029 andyli029 added this to the v1.3.0 milestone Jul 14, 2021
@andyli029 andyli029 added the P0 High priority label Jul 14, 2021
@andyli029 andyli029 self-assigned this Jul 14, 2021
@andyli029
Copy link
Contributor Author

andyli029 commented Jul 14, 2021 •
edited
Loading

like: thriftrw/thriftrw-go#465

andyli029 added a commit to andyli029/radondb-mysql-kubernetes that referenced this issue Jul 14, 2021
@andyli029
utils: fix go vet failed when go 1.16.6 radondb#139
1081b21 
[summary]
fix go vet failed when go 1.16.6

[test case]
utils/unsafe_test.go

[patch codecov]
utils/unsafe.go 100%
andyli029 added a commit to andyli029/radondb-mysql-kubernetes that referenced this issue Jul 14, 2021
@andyli029
utils: fix go vet failed when go 1.16.6 radondb#139
317fead 
[summary]
fix go vet failed when go 1.16.6

[test case]
utils/unsafe_test.go

[patch codecov]
utils/unsafe.go 100%
andyli029 added a commit to andyli029/radondb-mysql-kubernetes that referenced this issue Jul 14, 2021
@andyli029
utils: fix go vet failed when go 1.16.6 radondb#139
a39316b 
[summary]
fix go vet failed when go 1.16.6

[test case]
utils/unsafe_test.go

[patch codecov]
utils/unsafe.go 100%
@andyli029 andyli029 mentioned this issue Jul 14, 2021
Merged
andyli029 added a commit to andyli029/radondb-mysql-kubernetes that referenced this issue Jul 14, 2021
@andyli029
utils: Fix possible misuse of reflect.SliceHeader vet error when go 1…
1ccd649 
….16.6 radondb#139

[summary]
fix go vet failed when go 1.16.6

[test case]
utils/unsafe_test.go

[patch codecov]
utils/unsafe.go 100%
andyli029 added a commit that referenced this issue Jul 16, 2021
@andyli029
Merge pull request #141 from andyli029/fix_vet_1.16.6
b1ffd45 
utils: Fix possible misuse of reflect.SliceHeader vet error when go 1.16.6 #139
zhyass pushed a commit to zhyass/radondb-mysql-kubernetes that referenced this issue Jul 23, 2021
@andyli029 @zhyass
utils: Fix possible misuse of reflect.SliceHeader vet error when go 1…
9e17f22 
….16.6 radondb#139

[summary]
fix go vet failed when go 1.16.6

[test case]
utils/unsafe_test.go

[patch codecov]
utils/unsafe.go 100%
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this issue Aug 17, 2022
@andyli029
utils: Fix possible misuse of reflect.SliceHeader vet error when go 1…
21569d0 
….16.6 radondb#139

[summary]
fix go vet failed when go 1.16.6

[test case]
utils/unsafe_test.go

[patch codecov]
utils/unsafe.go 100%
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this issue Aug 17, 2022
@andyli029
Merge pull request radondb#141 from andyli029/fix_vet_1.16.6
a523a5e 
utils: Fix possible misuse of reflect.SliceHeader vet error when go 1.16.6 radondb#139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyli029 andyli029

Labels
bug Something isn't working P0 High priority
Projects
None yet
Milestone
v2.0.0
1 participant
@andyli029