-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Select] fix: disabled select when fieldset has disabled
attr
#3174
base: main
Are you sure you want to change the base?
Conversation
Will this react to changes? For example if the fieldset is dynamically disabled? |
@RndUsername export const Styled = () => {
const [disabled, setDisabled] = React.useState(false);
return (
<div>
<button type="button" onClick={() => setDisabled((prev) => !prev)}>
{disabled ? 'enabled' : 'disabled'}
</button>
<div>
<p>Radix `Select` component</p>
<fieldset disabled={disabled}>
{POSITIONS.map((position) => (
<Label key={position}>
Choose a number:
<Select.Root defaultValue="two">
...
</Select.Root>
</Label>
))}
</fieldset>
</div>
</div>
);
}; 2024-10-15.22.16.05.mov |
Ran into this today, can we get a review and merge? 🙏 |
Hey all, it's been 4 months can someone take a look at this? |
I feel like some people want it to be merged. So if need any help, I will be contributing or reviewing:) (I want to fix conflicts, but there is no permission to write this branch since I was not assigned on this PR) |
Description
close #2417
fieldset
,Select
component does not be disabled.Select.Trigger
hasonPointerDown
handler and even if button is disabled, that handler can be triggered.fieldset
disabled.AS-IS
2024-10-10.14.42.50.mov
TO-BE
2024-10-10.14.42.00.mov