Skip to content
This repository has been archived by the owner on Feb 28, 2021. It is now read-only.

runtime: Unregister user if not an org member #472

Merged
merged 1 commit into from
May 28, 2020

Conversation

NunoAlexandre
Copy link
Contributor

Closes #399

@NunoAlexandre NunoAlexandre self-assigned this May 26, 2020
@NunoAlexandre NunoAlexandre requested review from xla and geigerzaehler and removed request for xla May 26, 2020 12:57
@NunoAlexandre NunoAlexandre added this to the β1 milestone May 26, 2020
Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, just some formatting and clarifying questions.

runtime/src/registry.rs Outdated Show resolved Hide resolved
runtime/src/registry.rs Show resolved Hide resolved
runtime/src/registry.rs Outdated Show resolved Hide resolved
Copy link

@geigerzaehler geigerzaehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to upgrade spec_version and recompile the latest runtime.

runtime/src/registry.rs Outdated Show resolved Hide resolved
runtime/src/registry.rs Outdated Show resolved Hide resolved
runtime/src/registry.rs Show resolved Hide resolved
Also make the returned errors more granular, reflected in the test
coverage.
@NunoAlexandre
Copy link
Contributor Author

You also need to upgrade spec_version and recompile the latest runtime.

We don't really need to. The e2e tests are not affected and in this branch, we run against the native runtime. Is there any practical need to bump it? If not, I'd leave it until this is merged to master otherwise we are both bumping it on master and here, which is just difficult to linearize.

@NunoAlexandre NunoAlexandre force-pushed the runtime/unregister-user-check branch from c679ea5 to 31665e2 Compare May 27, 2020 11:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants