-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4972 Shape center and size not reflective of actual #5143
Conversation
…oft/sirepo into 4848-radia-stl-import-gui
Fix #4849 stl import test
… count error for validating imports
We should still display the size but disable the input fields. See sirepo/sirepo/package_data/static/js/radia.js Line 3841 in dcb249c
It's a one-line fix if you want to add it to this PR, but a new issue is fine too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment on centering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple minor comments
ping @Benbenbenin0 - a couple of changes still in queue here. If you need to focus on ldap that's ok - I'll fix this up; lmk one way or the other |
@mkeilman Thanks for the fixes and merge |
Merged #4971 into this PR along with #4972
Shapes are now built at center provided by dragging in the design tab, also now displays shapes using the same STL file.
Shape size is now updated to the actual after building from the imported file, however the design tab still leaves default values in the "size [mm]" field that do nothing when changed.
@mkeilman think we need a new issue for that? Not sure whether to let the user scale the STL's size in the designer, remove the field for STL's or do something else.