Fix #5018 remove global uid in flask #5064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 25 commits
October 28, 2022 01:40
|
Calls to SRW api_listFiles is failing with an assertion |
|
The warpvnd example "Lattice Gate 3D" is failing for the Field Calculation Status on the source page and the Simulation Status on the Visualization page. |
|
Looks good, I didn't find any other bugs when testing all the apps manually. |
|
warpvnd issues was related to #5118. Catching all places that require qcall is tricky when errors are suppressed. python_soruce_for_model is tricky. I'll check a few. |
added 3 commits
November 11, 2022 23:31
|
Tested all apps with a few examples each and exports from all. If tests pass, I think it's ready for a merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't don't extensive click around testing. Have not run jupyter. I'll do more testing. Just wanted to start the PR.