-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4848 Added STL Importing #4967
Conversation
…oft/sirepo into 4848-radia-stl-import-gui
@Benbenbenin0 fix the merge conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First thing to do is resolve the merge conflicts.
@Benbenbenin0 how go the fixes to this PR? If you fix the merge conflicts and commit them I can do a little testing. |
@mkeilman sorry should've prioritized fixing this PR, conflicts and changes are resolved. |
@Benbenbenin0 reminder to run the formatter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment, but you also need to run the formatter
@Benbenbenin0 can you investigate why the checks failed? |
The tests are failing for this PR, but pass on dev. I think it is related to the new trimesh requirement, and it might be missing from the ci test env. Something for @e-carlin or @robnagler to look at when they get a chance |
I started the sirepo-ci build. Once that's done, you can restart the workflow to see if the tests pass. |
Seems like the failures are still tied to Trimesh (All tests pass on my local machine and running it on github throws a missing submodule exception similar to the issue @e-carlin mentioned to me #4351). @robnagler @moellep not sure if the sirepo-ci build is finished or not, would I check by looking for a Sirepo commit relating to CI checks? |
… count error for validating imports
I forgot to rebuild rscode-radia so sirepo-ci won't have trimesh. @Benbenbenin0 I'm going to rebuild today and I'll followup when it is working. |
Looks like it is working now. |
Fix #4848