Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4848 Added STL Importing #4967

Merged
merged 28 commits into from
Nov 11, 2022
Merged

Fix #4848 Added STL Importing #4967

merged 28 commits into from
Nov 11, 2022

Conversation

Benbenbenin0
Copy link
Contributor

Fix #4848

  • Added STL importing to Radia with face building implementation
  • Left commented code for slicing implementation

@Benbenbenin0 Benbenbenin0 requested a review from mkeilman October 19, 2022 19:16
@Benbenbenin0 Benbenbenin0 linked an issue Oct 19, 2022 that may be closed by this pull request
3 tasks
@mkeilman
Copy link
Contributor

@Benbenbenin0 fix the merge conflicts

Copy link
Contributor

@mkeilman mkeilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First thing to do is resolve the merge conflicts.

@mkeilman
Copy link
Contributor

@Benbenbenin0 how go the fixes to this PR? If you fix the merge conflicts and commit them I can do a little testing.

@Benbenbenin0
Copy link
Contributor Author

@mkeilman sorry should've prioritized fixing this PR, conflicts and changes are resolved.

@Benbenbenin0 Benbenbenin0 requested a review from mkeilman October 25, 2022 21:16
@mkeilman
Copy link
Contributor

@Benbenbenin0 reminder to run the formatter

Copy link
Contributor

@mkeilman mkeilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, but you also need to run the formatter

@Benbenbenin0 Benbenbenin0 requested a review from mkeilman October 26, 2022 20:42
@mkeilman
Copy link
Contributor

@Benbenbenin0 can you investigate why the checks failed?

@Benbenbenin0 Benbenbenin0 reopened this Nov 3, 2022
@moellep
Copy link
Member

moellep commented Nov 4, 2022

The tests are failing for this PR, but pass on dev. I think it is related to the new trimesh requirement, and it might be missing from the ci test env. Something for @e-carlin or @robnagler to look at when they get a chance

@robnagler
Copy link
Member

I started the sirepo-ci build. Once that's done, you can restart the workflow to see if the tests pass.

@Benbenbenin0
Copy link
Contributor Author

Seems like the failures are still tied to Trimesh (All tests pass on my local machine and running it on github throws a missing submodule exception similar to the issue @e-carlin mentioned to me #4351). @robnagler @moellep not sure if the sirepo-ci build is finished or not, would I check by looking for a Sirepo commit relating to CI checks?

@e-carlin
Copy link
Member

I forgot to rebuild rscode-radia so sirepo-ci won't have trimesh. @Benbenbenin0 I'm going to rebuild today and I'll followup when it is working.

@e-carlin
Copy link
Member

Looks like it is working now.

@moellep moellep merged commit 55adeed into master Nov 11, 2022
@moellep moellep deleted the 4848-radia-stl-import-gui branch November 14, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

20221013 GUI for STL objects
5 participants