Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide source geometry if source particles is set to 0 #6706

Closed
moellep opened this issue Jan 30, 2024 · 1 comment
Closed

Hide source geometry if source particles is set to 0 #6706

moellep opened this issue Jan 30, 2024 · 1 comment
Milestone

Comments

@moellep
Copy link
Member

moellep commented Jan 30, 2024

Related to #4791

If someone sets the source particles to display to zero, it should also hide the source geometry.

This is especially needed for box geometries which use "only fissionable" since the source is actually the volumes contained which are depletable. Possibly don't show the box for box geometries in this case. See the zpre example.

Tally-Results-t1-flux-mean

@moellep moellep added this to the cloudmc milestone Jan 30, 2024
@mkeilman
Copy link
Contributor

I had additional thoughts - maybe this would be better with a "show sources" toggle and an enum of number of source particles, by 10s or something. I don't think you learn anything by showing 16 vs 20 particles. A filter by particle type and energy range might also be nice. And now it's getting complicated so perhaps a tab in tally settings or a separate panel would make sense (in a new issue)

mkeilman pushed a commit that referenced this issue Jan 30, 2024
mkeilman pushed a commit that referenced this issue Jan 31, 2024
mkeilman pushed a commit that referenced this issue Jan 31, 2024
mkeilman pushed a commit that referenced this issue Jan 31, 2024
mkeilman pushed a commit that referenced this issue Jan 31, 2024
@moellep moellep closed this as completed in 3281765 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants